Support for recorded and paused time - Modifications after 2nd code review

[FJBDev]

No description provided.

[wolfgang-ch]

I like the new time icons :-)

I've not yet merged into main, first I'll do more tests

[wolfgang-ch]

I've found/fixed an SQL exception 2281360
and changed a mnemonic c204991

These modifications are in your FJBDev branch

[FJBDev]

I like the new time icons :-)

I've not yet merged into main, first I'll do more tests

Thanks, I like them too!
But i am still not sure that I can use them as they don't work in Linux 😧

[FJBDev]

I've found/fixed an SQL exception 2281360
and changed a mnemonic c204991

These modifications are in your FJBDev branch

Thank you, i just looked at them, that looks good to me.

[FJBDev]

@wolfgang-ch That's what happens in Linux

[wolfgang-ch]

Ubuntu is OK

[wolfgang-ch]

New time icon sugesstions:

• Replaced elapsed icon with recorded icon
• New recorded icon
• Some suggestions for the moving icon. When searched for a new moving icon, I found this document https://www.unicode.org/L2/L2018/18090-tachograph-symbols.pdf, it is interresting to see for their process how to find a new icon, I googled for "unicode tacho"

Which is your preferred moving icon?

[wolfgang-ch]

Any unicode character could be used

Selecting a character is easy with LibreOffice

[wolfgang-ch]

I've a lot of tours with overlapped paused times at the beginning of the tour, zooming in do not help to read the displayed values

The tour segmenter shows stacked labels which prevents overlapping, this is done in net.tourbook.ui.tourChart.ValueOverlapChecker but the whole is a relative complex code :-)

[wolfgang-ch]

Some tours have negative paused time

[FJBDev]

Ubuntu is OK

Maybe it depends the desktop used. Are you using Gnome ? I am using Cinnamon

[FJBDev]

In GNOME,
In GNOME 3, the default font is Cantarell, Source : https://developer.gnome.org/hig/stable/typography.html.en

[FJBDev]

And in my Linux Debian 10.5 Cinnamon, this is what I have as a default font :

[FJBDev]

New time icon sugesstions:

* Replaced elapsed icon with recorded icon

* New recorded icon

* Some suggestions for the moving icon. When searched for a new moving icon, I found this document https://www.unicode.org/L2/L2018/18090-tachograph-symbols.pdf, it is interresting to see for their process how to find a new icon, I googled for "unicode tacho"

Which is your preferred moving icon?

My preferred moving icon is the one in the red square:

[FJBDev]

Any unicode character could be used

Not if it doesn't work on all the Linux 😧

[FJBDev]

I've a lot of tours with overlapped paused times at the beginning of the tour, zooming in do not help to read the displayed >values
The tour segmenter shows stacked labels which prevents overlapping, this is done in >net.tourbook.ui.tourChart.ValueOverlapChecker but the whole is a relative complex code :-)

I have seen this issue as well. I will look into this complex code net.tourbook.ui.tourChart.ValueOverlapChecker

[FJBDev]

Some tours have negative paused time

Are those tours old tours reimported ? are they new tours ? Which format are they ? FIT ? TCX ?
I have never seen this issue, this is not normal.

it's probably because the elapsed time is 1 second less than the recorded time:

My guess is that it's from a FIT file but the elapsed value should NOT be less than the recorded value.
I will fix that in my code but you will need to verify because I dont have such FIT files.

[FJBDev]

See my fix attempt here.
Does it fix your paused time of -1 issue ?

[wolfgang-ch]

And in my Linux Debian 10.5 Cinnamon, this is what I have as a default font :

I'm using Ubuntu 20.04 with it's default setup

[wolfgang-ch]

My preferred moving icon is the one in the red square:

Fixed

[wolfgang-ch]

Any unicode character could be used

Not if it doesn't work on all the Linux 😧

I would understand that 3-Byte Unicode characters, e.g. all of these moving time icons

are not supported but you have choosen only 2-Byte Unicode characters

[wolfgang-ch]

Some tours have negative paused time

Are those tours old tours reimported ? are they new tours ? Which format are they ? FIT ? TCX ?
I have never seen this issue, this is not normal.

it's probably because the elapsed time is 1 second less than the recorded time:

My guess is that it's from a FIT file but the elapsed value should NOT be less than the recorded value.
I will fix that in my code but you will need to verify because I dont have such FIT files.

This issue occurred with FIT files, imported and reimported

[wolfgang-ch]

Statistic paused time value is larger than elapsed time value

[wolfgang-ch]

Missing mnemonics

[wolfgang-ch]

I've several tours with wrong paused time, these are mainly tours which I recorded when driving by car but I also found 1 normal bicycle tour with wrong paused time value. These tours are all recorded with an Edge 1030 -> FIT format.

[FJBDev]

Some tours have negative paused time

Are those tours old tours reimported ? are they new tours ? Which format are they ? FIT ? TCX ?
I have never seen this issue, this is not normal.
it's probably because the elapsed time is 1 second less than the recorded time:

My guess is that it's from a FIT file but the elapsed value should NOT be less than the recorded value.
I will fix that in my code but you will need to verify because I dont have such FIT files.

This issue occurred with FIT files, imported and reimported

Did you try with my new code available in my latest PR?

[FJBDev]

I've several tours with wrong paused time, these are mainly tours which I recorded when driving by car but I also found 1 normal bicycle tour with wrong paused time value. These tours are all recorded with an Edge 1030 -> FIT format.

I can't reproduce the issue so I'm not sure I can troubleshoot....unless you can share one or more FIT files ?

[FJBDev]

And in my Linux Debian 10.5 Cinnamon, this is what I have as a default font :

I'm using Ubuntu 20.04 with it's default setup

Ok, so it shows that you are using GNOME 3 on your Ubuntu, so maybe it's because GNOME and Cinnamon use a different font ?

[FJBDev]

Missing mnemonics

Fixed

[FJBDev]

Any unicode character could be used

Not if it doesn't work on all the Linux 😧

I would understand that 3-Byte Unicode characters, e.g. all of these moving time icons

are not supported but you have choosen only 2-Byte Unicode characters

Maybe it's the default font used by GNOME and Cinnamon ?
I will continue to investigate.

[wolfgang-ch]

This PR is now merged into main, it was a long reviewing time.

Some more issues which I found:

• Unit column should show only units

• One missing mnemonic

[FJBDev]

Some more issues which I found:

* Unit column should show only units

This is what is in the official 20.8 so I thought it was normal to have the unit the same as the column header:

I can fix

[FJBDev]

* One missing mnemonic

Fixed

[wolfgang-ch]

This is what is in the official 20.8 so I thought it was normal to have the unit the same as the column header:

I can fix

It looked a bit strange when I first saw it and why I created this "issue". So we can keep it except "Recorded time" which shows a text

[FJBDev]

It looked a bit strange when I first saw it and why I created this "issue". So we can keep it except "Recorded time" which shows a text

Whatever you prefer but actually the menu is very confusing to me because I don't understand the difference between the "Tour Format" column and the "Unit" column. It seems they are the same to me ?

[wolfgang-ch]

• Tour Format: how values are formatted

• Unit: when searching references then you can see where units are used

[wolfgang-ch]

See my fix attempt here.
Does it fix your paused time of -1 issue ?

YES !

Old

New

[FJBDev]

I've a lot of tours with overlapped paused times at the beginning of the tour, zooming in do not help to read the displayed values

The tour segmenter shows stacked labels which prevents overlapping, this is done in net.tourbook.ui.tourChart.ValueOverlapChecker but the whole is a relative complex code :-)

Implemented the overlap for TourChart pauses in my recent PR