Changed the behavior of add_bias()

myui · Aug 4, 2014 · dc46f73 · dc46f73
1 parent 25df4a7
commit dc46f73
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/scripts/ddl/define-ftvec-udf.hive b/scripts/ddl/define-ftvec-udf.hive
@@ -52,12 +52,20 @@ create temporary function rand_amplify as 'hivemall.ftvec.amplify.RandomAmplifie
 drop temporary function conv2dense;
 create temporary function conv2dense as 'hivemall.ftvec.ConvertToDenseModelUDAF';
 
+-- for backward compatibility
 drop temporary function addBias;
 create temporary function addBias as 'hivemall.ftvec.AddBiasUDF';
 
+drop temporary function add_bias;
+create temporary function add_bias as 'hivemall.ftvec.AddBiasUDF';
+
+-- for backward compatibility
 drop temporary function sortByFeature;
 create temporary function sortByFeature as 'hivemall.ftvec.SortByFeatureUDF';
 
+drop temporary function sort_by_feature;
+create temporary function sort_by_feature as 'hivemall.ftvec.SortByFeatureUDF';
+
 drop temporary function extract_feature;
 create temporary function extract_feature as 'hivemall.ftvec.ExtractFeatureUDF';
 

diff --git a/src/main/hivemall/HivemallConstants.java b/src/main/hivemall/HivemallConstants.java
@@ -22,8 +22,7 @@
 
 public final class HivemallConstants {
 
-    public static final String BIAS_CLAUSE = "+bias";
-    public static final int BIAS_CLAUSE_INT = -1;
+    public static final String BIAS_CLAUSE = "0";
 
     // org.apache.hadoop.hive.serde.Constants (hive 0.9)
     // org.apache.hadoop.hive.serde.serdeConstants (hive 0.10 or later)

diff --git a/src/main/hivemall/ftvec/AddBiasUDF.java b/src/main/hivemall/ftvec/AddBiasUDF.java
@@ -32,13 +32,12 @@
 import org.apache.hadoop.io.IntWritable;
 import org.apache.hadoop.io.Text;
 
-@Description(name = "addBias", value = "_FUNC_(feature_vector in array<string>) - Returns features with a bias in array<string>")
+@Description(name = "add_bias", value = "_FUNC_(feature_vector in array<string>) - Returns features with a bias in array<string>")
 @UDFType(deterministic = true, stateful = false)
 public final class AddBiasUDF extends UDF {
 
     public List<Text> evaluate(List<String> ftvec) {
-        String biasClause = Integer.toString(HivemallConstants.BIAS_CLAUSE_INT);
-        return evaluate(ftvec, biasClause);
+        return evaluate(ftvec, HivemallConstants.BIAS_CLAUSE);
     }
 
     public List<Text> evaluate(List<String> ftvec, String biasClause) {