Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle numbers on/off on WinEnter/WinLeave #28

Merged
merged 2 commits into from
Jul 12, 2013
Merged

Toggle numbers on/off on WinEnter/WinLeave #28

merged 2 commits into from
Jul 12, 2013

Conversation

mrpdaemon
Copy link
Contributor

When working with multiple split windows, it makes more sense for only
the active window to be in relative number mode and for all the other
windows to be in absolute number mode.

When working with multiple split windows, it makes more sense for only
the active window to be in relative number mode and for all the other
windows to be in absolute number mode.
@myusuf3
Copy link
Owner

myusuf3 commented Apr 22, 2013

@mrpdaemon I am not mad at you for this. I might even like it. Let me try it out and lets see what we can do.

Can you also update the documentation for its potential merger.

@mrpdaemon
Copy link
Contributor Author

I did update the documentation, however it looks like my change doesn't work right in all cases - it only works when a new window is created with :split or :vsplit but not when its combined with opening a new buffer, ie :split or :vsplit results in the old window remaining in relative mode. I'll look deeper into this and figure out how to get it working right for those cases.

@mrpdaemon
Copy link
Contributor Author

GitHub ate my tags there, meant that :split FILENAME or :vsplit FILENAME doesn't work right.

@mrpdaemon
Copy link
Contributor Author

Nevermind my previous two comments, the problem was due to a development version of MiniBufExpl which for some reason screws up with WinEnter and WinLeave events. The change works fine with the stable version of MiniBufExpl or without MiniBufExpl, so this should be good to merge if you like the behavior.

@sethfowler
Copy link

I'm glad to see there's demand for this from more than just me. My pull request #27 also adds this feature. I used BufEnter and BufLeave instead of WinEnter and WinLeave, though.

@myusuf3
Copy link
Owner

myusuf3 commented May 3, 2013

@mrpdaemon @Sfowler This will likely be the on that I merged so I am going to close the other. I just need to make sure it works before I merge it in.

@RyanMcG
Copy link
Contributor

RyanMcG commented Jul 11, 2013

👍 This PR works for me. In fact I've merged it into the development branch of my fork and have been using it happily.

See RyanMcG#2 and my development branch.

myusuf3 added a commit that referenced this pull request Jul 12, 2013
Toggle numbers on/off on WinEnter/WinLeave
@myusuf3 myusuf3 merged commit 3606caf into myusuf3:master Jul 12, 2013
RyanMcG added a commit to RyanMcG/dotfiles that referenced this pull request Jul 12, 2013
@mrpdaemon mrpdaemon deleted the toggle-on-window-enter-leave branch July 12, 2013 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants