-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle numbers on/off on WinEnter/WinLeave #28
Toggle numbers on/off on WinEnter/WinLeave #28
Conversation
When working with multiple split windows, it makes more sense for only the active window to be in relative number mode and for all the other windows to be in absolute number mode.
@mrpdaemon I am not mad at you for this. I might even like it. Let me try it out and lets see what we can do. Can you also update the documentation for its potential merger. |
I did update the documentation, however it looks like my change doesn't work right in all cases - it only works when a new window is created with :split or :vsplit but not when its combined with opening a new buffer, ie :split or :vsplit results in the old window remaining in relative mode. I'll look deeper into this and figure out how to get it working right for those cases. |
GitHub ate my tags there, meant that :split FILENAME or :vsplit FILENAME doesn't work right. |
Nevermind my previous two comments, the problem was due to a development version of MiniBufExpl which for some reason screws up with WinEnter and WinLeave events. The change works fine with the stable version of MiniBufExpl or without MiniBufExpl, so this should be good to merge if you like the behavior. |
I'm glad to see there's demand for this from more than just me. My pull request #27 also adds this feature. I used BufEnter and BufLeave instead of WinEnter and WinLeave, though. |
@mrpdaemon @Sfowler This will likely be the on that I merged so I am going to close the other. I just need to make sure it works before I merge it in. |
👍 This PR works for me. In fact I've merged it into the development branch of my fork and have been using it happily. See RyanMcG#2 and my development branch. |
Toggle numbers on/off on WinEnter/WinLeave
Helpful features were merged into it. See myusuf3/numbers.vim#28 and myusuf3/numbers.vim#32.
When working with multiple split windows, it makes more sense for only
the active window to be in relative number mode and for all the other
windows to be in absolute number mode.