Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind template reference on when script is run #2

Merged
merged 1 commit into from
Jun 14, 2018
Merged

Bind template reference on when script is run #2

merged 1 commit into from
Jun 14, 2018

Conversation

paulerickson
Copy link
Member

No description provided.

@paulerickson paulerickson self-assigned this Jun 14, 2018
davidmsibley
davidmsibley approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@davidmsibley davidmsibley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only question would be whether the document is ready to be queried at that time?

@paulerickson
Copy link
Member Author

@davidmsibley yes, in fact it isn't available any later—currently, an exception is thrown because currentScript is undefined when the constructor is invoked (the script already ran by then).

@paulerickson paulerickson merged commit 445bcbd into myuw-web-components:master Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidmsibley davidmsibley davidmsibley approved these changes

@thevoiceofzeke thevoiceofzeke Awaiting requested review from thevoiceofzeke

@jvanboxtel jvanboxtel Awaiting requested review from jvanboxtel

@saberg3 saberg3 Awaiting requested review from saberg3

Assignees

@paulerickson paulerickson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@paulerickson @davidmsibley