Add cpu usage stats to heartbeat messages #14
Conversation
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
+ Coverage 78.25% 78.7% +0.44%
=========================================
Files 19 19
Lines 860 864 +4
Branches 78 78
=========================================
+ Hits 673 680 +7
+ Misses 169 165 -4
- Partials 18 19 +1
Continue to review full report at Codecov.
|
| @@ -371,6 +377,14 @@ public void run() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| private int getCpuUsage() { | |||
| return (int) osBean.getSystemCpuLoad() * 100; | |||
There was a problem hiding this comment.
Why don't we use getProcessCpuLoad and return a float number?
There was a problem hiding this comment.
I believe Locust is interested in the CPU usage of the entire machine in case there are other processes pegging the CPU. As I understand the concern is that the task will provide inaccurate results if it's restricted by underlying hardware, so the JVM process load isn't enough information.
As far as int vs. float, I'm actually not sure.
Locust since 0.14.0 requires CPU usage to be reported by clients. Somehow this also prevented the master from properly recording heartbeats (although I'm not sure how, as that happens earlier in the control flow).
CPU usage extraction: https://github.com/locustio/locust/blob/93eec54bd53576304c925ceb8c1e8de5981d7b24/locust/runners.py#L462
Heartbeat reset: https://github.com/locustio/locust/blob/93eec54bd53576304c925ceb8c1e8de5981d7b24/locust/runners.py#L460
No matter, this should be included and also appears to fix the heartbeat issue.