Don't use utils.forEach to loop over arguments #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ctimmerm would you mind rebasing your branch from master? |
This fixes IE8 support, where we cannot relialably detect an arguments object.
ctimmerm
force-pushed
the
ie8-arguments-foreach
branch
from
a85b34a
to
1e2cb9b
Compare
|
@mzabriskie done. |
mzabriskie
added a commit
that referenced
this pull request
Oct 28, 2015
Don't use utils.forEach to loop over arguments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #91 IE8 support has been broken.
This fixes it by not using utils.forEach to loop over
arguments(since in IE8 you can't reliably detect if a variable is an arguments object).