Skip to content

Commit

Permalink
Add editor drop target for notebooks
Browse files Browse the repository at this point in the history
  • Loading branch information
roblourens committed Jun 8, 2020
1 parent d436dae commit 9c7e230
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
Expand Up @@ -19,6 +19,7 @@ import { INotebookEditorViewState, NotebookViewModel } from 'vs/workbench/contri
import { IEditorGroup, IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService';
import { NotebookEditorWidget } from 'vs/workbench/contrib/notebook/browser/notebookEditorWidget';
import { NotebookRegistry } from 'vs/workbench/contrib/notebook/browser/notebookRegistry';
import { EditorPart } from 'vs/workbench/browser/parts/editor/editorPart';

const NOTEBOOK_EDITOR_VIEW_STATE_PREFERENCE_KEY = 'NotebookEditorViewState';

Expand All @@ -38,7 +39,7 @@ export class NotebookEditor extends BaseEditor {
@IThemeService themeService: IThemeService,
@IInstantiationService private readonly instantiationService: IInstantiationService,
@IStorageService storageService: IStorageService,
@IEditorGroupsService editorGroupService: IEditorGroupsService) {
@IEditorGroupsService private readonly editorGroupService: IEditorGroupsService) {
super(NotebookEditor.ID, telemetryService, themeService, storageService);

// this._widget = this.instantiationService.createInstance(NotebookEditorWidget);
Expand Down Expand Up @@ -182,6 +183,12 @@ export class NotebookEditor extends BaseEditor {

await this._widget.setModel(model.notebook, viewState, options);
this._widgetDisposableStore.add(this._widget.onDidFocus(() => this._onDidFocusWidget.fire()));

if (this.editorGroupService instanceof EditorPart) {
this._widgetDisposableStore.add(this.editorGroupService.createEditorDropTarget(this._widget.getDomNode(), {
groupContainsPredicate: (group) => this.group?.id === group.group.id
}));
}
}

clearInput(): void {
Expand Down

0 comments on commit 9c7e230

Please sign in to comment.