Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

修正: SceneCollectionのmanifestファイル読み込み失敗を収集(エラー調査用) #189

Merged
merged 1 commit into from Nov 1, 2018
Merged

修正: SceneCollectionのmanifestファイル読み込み失敗を収集(エラー調査用) #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions app/services/scene-collections/state.ts
View file
Open in desktop
Expand Up @@ -55,6 +55,14 @@ export class SceneCollectionsStateService extends StatefulService<
}
} catch (e) {
console.warn('Error loading manifest file from disk');
// 存在しない場合はそのまま初期化してよいのでスルー

// 存在しない以外の理由で失敗する場合は上書きしてしまうので問題がある
if (e.code !== 'ENOENT') {
console.error('Error loading manifest file from disk : %o', e);

// TODO: 上書き確認をする https://github.com/n-air-app/n-air-app/pull/180
}
}

await this.flushManifestFile();
Expand Down