追加: インターレース解除機能 #54
Merged
追加: インターレース解除機能 #54
+166
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koizuka
reviewed
Aug 29, 2018
| "yadif2x": "Yadif 2x", | ||
| "top_field_first": "Top field first", | ||
| "bottom_field_first": "Bottom field first" | ||
| } |
koizuka
reviewed
Aug 29, 2018
app/util/menus/DeinterlaceMenu.ts
Outdated
| } | ||
|
|
||
| appendMenuItems() { | ||
| this.append({ |
There was a problem hiding this comment.
ここから手書きで全要素記述してるけど、なんか自動列挙できないのかな
There was a problem hiding this comment.
EDeinterlaceModeとEDeinterlaceFieldOrderがconst enumなので、単純にfor inで列挙はできなさそうですね。
const DEINTERLACE_MODES = [
{ name: 'Disable', value: EDeinterlaceMode.Disable, label: $t('deinterlace.disable') },
...
];みたいな配列を前で配列を定義しておいて、実際にメニューを追加する部分を共通化することだったらできそうです。
|
❌ build failed |
1 similar comment
|
❌ build failed |
|
動画ソースの動作確認はしました。 キャプチャボードでの動作確認がしたい。 |
koizuka
approved these changes
Aug 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
このpull requestが解決する内容
インターレース解除機能を追加します。
動作確認手順