Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buffers #16

Merged
merged 2 commits into from
Oct 7, 2016
Merged

Buffers #16

merged 2 commits into from
Oct 7, 2016

Conversation

rgbkrk
Copy link
Contributor

@rgbkrk rgbkrk commented Oct 7, 2016

Closes #14

@rgbkrk rgbkrk mentioned this pull request Oct 7, 2016
Merged
@n-riesco
Copy link
Owner

n-riesco commented Oct 7, 2016

This line and this line also need updating.

😞 that the tests didn't catch this problem.

@n-riesco n-riesco mentioned this pull request Oct 7, 2016
Closed
@rgbkrk
Copy link
Contributor Author

rgbkrk commented Oct 7, 2016

Thanks for the thorough review, rebased with new commits.

@n-riesco n-riesco merged commit 59738e3 into n-riesco:master Oct 7, 2016
@rgbkrk rgbkrk deleted the buffers branch October 7, 2016 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgbkrk @n-riesco