Skip to content

Commit

Permalink
fix(iroh-net): Do not unwrap sending on response channel (#1529)
Browse files Browse the repository at this point in the history
## Description

This response is not critical.  If someone dropped the receiver it's
just fine, it meant they didn't care about the response anymore.

This has occurred during shutdown.

Part of #1528

## Notes & open questions

## Change checklist

- [x] Self-review.
- [x] ~~Documentation updates if relevant.~~
- [x] ~~Tests if relevant.~~
  • Loading branch information
flub committed Sep 27, 2023
1 parent 5d9322a commit 974b66e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion iroh-net/src/magicsock.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1172,7 +1172,7 @@ impl Actor {
}
ActorMessage::AddKnownAddr(addr, s) => {
self.add_known_addr(addr);
s.send(()).unwrap();
s.send(()).ok();
}
ActorMessage::ReceiveDerp(read_result) => {
let passthroughs = self.process_derp_read_result(read_result).await;
Expand Down

0 comments on commit 974b66e

Please sign in to comment.