-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(netcheck): Integrate https and icmp probes in probeplan #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
approved these changes
Jul 13, 2023
/netsim branch bump-ipv6-config |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The HTTPS and ICMP probes only need to run after the STUN probes have
failed. This is done in the probe plan by sequencing them after the
stun probes. If the STUN probes succeed the probe_would_help logic
will shortcut execution.
Because this was all constantly looking up DerpNodes in the DerpMap
they are now created once and put on the heap when the plan is
created. This means the ProbeReports now carry enough data that they
don't need looking up yet again.
Closes #1138
Notes & open questions
Because we only have one derp server currently, we never reach enough regions to abort all the probes. This means we end up waiting for the start of the icmp & http probes. Once they start the probe-would-help check however aborts the probe sets.I'm not really happy with that, it would be better if the probesets for a region would be aborted right away once the region is done. This ties in with the other refactor of moving the probe-would-help logic upside down that I've already mentioned (see #1180 (review)).It's probably fine for now if we create an issue for it?The solution is enough enough: 3bd0108
Change checklist