Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tests to in memory #1229

Closed
rklaehn opened this issue Jul 13, 2023 · 3 comments
Closed

Convert tests to in memory #1229

rklaehn opened this issue Jul 13, 2023 · 3 comments
Labels
refactor a change that neither fixes a bug nor adds a feature test

Comments

@rklaehn
Copy link
Contributor

rklaehn commented Jul 13, 2023

There are a large number of tests which use files which are not meant to test file IO.

They can all be replaced with tests that work with an in memory database. Maybe that helps with test execution times.

Look for this:

Path::new(env!("CARGO_MANIFEST_DIR")).join("README.md");
@dignifiedquire dignifiedquire added refactor a change that neither fixes a bug nor adds a feature test labels Jul 13, 2023
@rklaehn
Copy link
Contributor Author

rklaehn commented Jul 14, 2023

Implemented in #1232

@dignifiedquire
Copy link
Contributor

can we close this?

@rklaehn
Copy link
Contributor Author

rklaehn commented Jul 17, 2023

I think most tests are now in mem. We don't want them all to be in mem, otherwise we would never test the file io stuff. So I think we can close this.

@rklaehn rklaehn closed this as completed Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor a change that neither fixes a bug nor adds a feature test
Projects
Archived in project
Development

No branches or pull requests

2 participants