Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: rpc-port argument is confusing and partially broken #1639

Closed
dignifiedquire opened this issue Oct 16, 2023 · 0 comments · Fixed by #1739
Closed

cli: rpc-port argument is confusing and partially broken #1639

dignifiedquire opened this issue Oct 16, 2023 · 0 comments · Fixed by #1739
Assignees
@dignifiedquire
Labels
bug Something isn't working c-iroh
Milestone
v0.9.0

Comments

@dignifiedquire
Copy link
Contributor

Currently when running iroh --rpc-port PORT start it will be ignored, but for all other commands this is the position it has to be. For it to be accepted iroh start --rpc-port PORT has to be used.
@dignifiedquire dignifiedquire added bug Something isn't working c-iroh labels Oct 16, 2023
@dignifiedquire dignifiedquire modified the milestones: v0.8.0, v0.9.0 Oct 16, 2023
@dignifiedquire dignifiedquire self-assigned this Oct 26, 2023
dignifiedquire added a commit that referenced this issue Oct 26, 2023
@dignifiedquire
fix(iroh): handle rpc args in any position
a88cb36 
Closes #1639
@dignifiedquire dignifiedquire mentioned this issue Oct 26, 2023
Merged
dignifiedquire added a commit that referenced this issue Oct 30, 2023
@dignifiedquire
fix(iroh): handle rpc args in any position
7f965ba 
Closes #1639
github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2023
@dignifiedquire
fix(iroh): handle rpc args in any position (#1739)
0ca61ad 
It is now possible to do any of these 

```
> iroh start --rpc-port 1234
> iroh --rpc-port 1234 start
> iroh console --rpc-port 1234
> iroh --rpc-port 1234 console
```

Closes #1639
divagant-martian pushed a commit to divagant-martian/iroh that referenced this issue Oct 31, 2023
@dignifiedquire @divagant-martian
fix(iroh): handle rpc args in any position (n0-computer#1739)
67b14f7 
It is now possible to do any of these 

```
> iroh start --rpc-port 1234
> iroh --rpc-port 1234 start
> iroh console --rpc-port 1234
> iroh --rpc-port 1234 console
```

Closes n0-computer#1639
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dignifiedquire dignifiedquire

Labels
bug Something isn't working c-iroh
Projects
iroh
Archived in project
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

fix(iroh): handle rpc args in any position n0-computer/iroh
1 participant
@dignifiedquire