feat(iroh): add more rpc methods #1962
Conversation
Allows to efficiently read parts of a blob via RPC
|
Cool I thought to add this quite a while ago already. Is there a reason to keep both |
iroh/src/client.rs
Outdated
| DownloadProgress, ListTagsRequest, ListTagsResponse, NodeConnectionInfoRequest, | ||
| NodeConnectionInfoResponse, NodeConnectionsRequest, NodeShutdownRequest, NodeStatsRequest, | ||
| NodeStatusRequest, NodeStatusResponse, ProviderService, SetTagOption, ShareMode, WrapOption, | ||
| BlobListRequest, BlobListResponse, BlobReadAtRequest, BlobReadAtResponse, BlobReadRequest, |
There was a problem hiding this comment.
This import section seems to indicate that wildcard imports aren't that bad after all....
iroh/src/node.rs
Outdated
| (1, len) | ||
| } else { | ||
| ( | ||
| (len as f64 / max_chunk_size as f64).ceil() as usize, |
There was a problem hiding this comment.
weird to use f64 here... It is shorter than the integer variant, but will fail if len or max_chunk_size is > 2^53.
There was a problem hiding this comment.
how would I round up otherwise?
There was a problem hiding this comment.
len / max_chunk_size + if len % max_chunk_size == 0 { 0 } else { 1 }or
len / max_chunk_size + (len % max_chunk_size !=0) as usizeor something. With a bit of luck the optimizer will do only 1 integer division for both division and rest.
There was a problem hiding this comment.
Note that I don't worry about speed here. It's just weird to use fp for integer ops, and it will fail in weird ways as soon as you exceed the range of integers that can be losslessly represented in a fp num.
There was a problem hiding this comment.
ah yes, that is of course nice
allows fetching a collection via rpc
dignifiedquire
changed the title
dignifiedquire
force-pushed
the
feat-blob-read-at
branch
from
02f04d9
to
c3abd8f
Compare
done |
- add `blobs.read_at`: Allows to efficiently read parts of a blob via RPC - add `blobs.get_collection`: read a collection
blobs.read_at: Allows to efficiently read parts of a blob via RPCblobs.get_collection: read a collection