Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blob_download unnecessarily tries to connect to a peer even if the requested blob is found locally. #1947

Closed
expenses opened this issue Jan 11, 2024 · 2 comments · Fixed by #1969
Closed

blob_download unnecessarily tries to connect to a peer even if the requested blob is found locally. #1947

expenses opened this issue Jan 11, 2024 · 2 comments · Fixed by #1969
Labels
bug Something isn't working c-iroh
Milestone
v0.13.0

Comments

@expenses
Copy link
Contributor

I ran into this issue when testing the RPC interface, by taking a BlobTicket, deconstructing it, constructing a BlobDownloadRequest and calling BlobsClient::download. It's trivial to work around, simply call BlobsClient::read or BlobsClient::read_to_bytes first and use that result if you don't get an error. Perhaps this behaviour is intended, but it's a little unintuitive.
@ramfox ramfox added this to the v0.13.0 milestone Jan 11, 2024
@dignifiedquire dignifiedquire added c-iroh bug Something isn't working labels Jan 18, 2024
@dignifiedquire
Copy link
Contributor

Yes, we should avoid creating network connections if we don't actually need them

@dignifiedquire
Copy link
Contributor

This is fixed in #1962

@dignifiedquire dignifiedquire mentioned this issue Jan 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jan 23, 2024
@dignifiedquire
fix(iroh): do not establish connection if content already exists loca…
f7264ff 
…lly (#1969)

Avoid establishing a connection in `blobs.download` if content is
already locally available.

Closes #1947
@expenses expenses mentioned this issue Feb 2, 2024
Open
fubuloubu pushed a commit to ApeWorX/iroh that referenced this issue Feb 21, 2024
@dignifiedquire @fubuloubu
fix(iroh): do not establish connection if content already exists loca…
38f59d6 
…lly (n0-computer#1969)

Avoid establishing a connection in `blobs.download` if content is
already locally available.

Closes n0-computer#1947
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working c-iroh
Projects
iroh
Archived in project
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

fix(iroh): do not establish connection if content already exists locally n0-computer/iroh
3 participants
@dignifiedquire @expenses @ramfox