Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic in netdev #2448

Closed
rklaehn opened this issue Jul 2, 2024 · 1 comment · Fixed by #2528
Closed

Panic in netdev #2448

rklaehn opened this issue Jul 2, 2024 · 1 comment · Fixed by #2528
Labels
bug Something isn't working c-iroh-net

Comments

@rklaehn
Copy link
Contributor

rklaehn commented Jul 2, 2024 

2024-07-02T16:29:13.015335Z  INFO iroh_net::net::netmon::actor: potential change
thread 'tokio-runtime-worker' panicked at /Users/rklaehn/.cargo/registry/src/index.crates.io-6f17d22bba15001f/netdev-0.27.0/src/gateway/macos.rs:428:9:
assertion `left == right` failed
  left: 0
 right: 5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

Just saw this. Does not seem to have any serious consequences, but just wanted to report it.
@rklaehn rklaehn added bug Something isn't working c-iroh-net labels Jul 2, 2024
@dignifiedquire
Copy link
Contributor

This is the relevant line: https://github.com/shellrow/netdev/blob/main/src/gateway/macos.rs#L428

we should file this as an issue with netdev

@dignifiedquire dignifiedquire mentioned this issue Jul 3, 2024
Closed
@dignifiedquire dignifiedquire mentioned this issue Jul 22, 2024
Merged
4 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 22, 2024
@dignifiedquire
feat(iroh-net): update netdev to 0.30 (#2528)
214bb0c 
## Description

Closes #2448

## Breaking Changes

<!-- Optional, if there are any breaking changes document them,
including how to migrate older code. -->

## Notes & open questions

<!-- Any notes, remarks or open questions you have to make about the PR.
-->

## Change checklist

- [x] Self-review.
- [x] Documentation updates following the [style
guide](https://rust-lang.github.io/rfcs/1574-more-api-documentation-conventions.html#appendix-a-full-conventions-text),
if relevant.
- [x] Tests if relevant.
- [x] All breaking changes documented.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working c-iroh-net
Projects
iroh
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iroh-net): update netdev to 0.30 n0-computer/iroh
2 participants
@rklaehn @dignifiedquire