Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use chunk groups feature #798

Merged
merged 2 commits into from
Mar 9, 2023
Merged

feat: use chunk groups feature #798

merged 2 commits into from
Mar 9, 2023

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Feb 27, 2023

caution: this is not compatible with existing iroh/sendme

caution: this is not compatible with existing iroh/sendme
@dignifiedquire
Copy link
Contributor

what's missing here, given this is a draft?

@rklaehn
Copy link
Contributor Author

rklaehn commented Mar 1, 2023

It was a draft because the crate was not published yet, and the tests were failing. Let's see, maybe they work now...

@rklaehn rklaehn marked this pull request as ready for review March 1, 2023 15:51
@dignifiedquire
Copy link
Contributor

/perf

@dignifiedquire
Copy link
Contributor

/netsim

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

body: |
.
Perf report

test case throughput_gbps
iperf 1_to_1 67.20
iperf 1_to_3 107.60
iperf 1_to_5 163.50
iperf 1_to_10 187.60
iperf 2_to_2 71.60
iperf 2_to_4 125.30
iperf 2_to_6 163.70
iperf 2_to_10 192.00
iperf_udp 1_to_1 5.68
iperf_udp 1_to_3 -0.00
iperf_udp 1_to_5 25.47
iperf_udp 1_to_10 41.69
iperf_udp 2_to_2 10.92
iperf_udp 2_to_4 20.93
iperf_udp 2_to_6 30.24
iperf_udp 2_to_10 41.10
iroh 1_to_1 1.80
iroh 1_to_3 4.99
iroh 1_to_5 4.83
iroh 1_to_10 4.28
iroh 2_to_2 3.45
iroh 2_to_4 6.89
iroh 2_to_6 9.47
iroh 2_to_10 12.06
chuck_tls 1_to_1 5.78
chuck_tls 1_to_3 17.83
chuck_tls 1_to_5 27.48
chuck_tls 1_to_10 39.90
chuck_tls 2_to_2 15.22
chuck_tls 2_to_4 21.87
chuck_tls 2_to_6 36.76
chuck_tls 2_to_10 54.87
chuck_http 1_to_1 27.71
chuck_http 1_to_3 52.52
chuck_http 1_to_5 66.20
chuck_http 1_to_10 72.24
chuck_http 2_to_2 49.77
chuck_http 2_to_4 80.46
chuck_http 2_to_6 104.02
chuck_http 2_to_10 179.27

@dignifiedquire
Copy link
Contributor

@rklaehn do we want to ship this? did you compare the perf numbers?

@rklaehn
Copy link
Contributor Author

rklaehn commented Mar 9, 2023

Well, perf is basically identical, a tad faster. The main benefit is that the outboard is smaller, so we can share larger files with outboard in memory.

As far as I am concerned it is ready to go - provided that we're clear that this might change in the future, together with the protocol.

@dignifiedquire
Copy link
Contributor

@flub any concerns merging this before DC release?

@flub
Copy link
Contributor

flub commented Mar 9, 2023

@flub any concerns merging this before DC release?

i guess there's no problem with merging this?

@rklaehn rklaehn merged commit d68f05d into main Mar 9, 2023
@rklaehn rklaehn deleted the chunky2 branch March 9, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants