feat: streaming blob reads over RPC #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frando
force-pushed
the
rpc-stream-blobs
branch
from
b45ca8e
to
e27bd15
Compare
rklaehn
approved these changes
Sep 13, 2023
| fn bytes_get( | ||
| self, | ||
| req: BytesGetRequest, | ||
| ) -> impl Stream<Item = RpcResult<BytesGetResponse>> + Send + 'static { |
There was a problem hiding this comment.
This works fine and should not be an issue in this case.
But if quic-rpc would optionally give you a sender instead of requiring a signature that returns a stream the additional channel could be avoided.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes getting blobs over RPC streaming. Before we'd alloc the full blob in-memory, which of course is a no-go.
Notes & open questions
Client API methods will be renamed in the upcoming API refactor.
Change checklist