fix(iroh): check output for blob get #1898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check we the result can be written to, before downloading.
iroh/src/commands/blob.rs
Outdated
| @@ -217,6 +217,10 @@ impl BlobCommands { | |||
| Some(OutputTarget::Stdout) => DownloadLocation::Internal, | |||
| Some(OutputTarget::Path(ref path)) => { | |||
| let absolute = std::env::current_dir()?.join(path); | |||
| ensure!( | |||
| absolute.is_file() || !absolute.exists(), | |||
There was a problem hiding this comment.
if it's a single blob and the absolute does not exist we probably also want to check that the parent does exist
There was a problem hiding this comment.
or should we just create the full path if not? 🤔
divagant-martian
approved these changes
Dec 18, 2023
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
Check we the result can be written to, before downloading.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check we the result can be written to, before downloading.