fix(iroh): add timestamp method to Entry RPC struct #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flub
reviewed
Jan 12, 2024
| @@ -871,6 +871,11 @@ impl Entry { | |||
| self.0.key() | |||
| } | |||
|
|
|||
| /// Get the timestamp of this entry. | |||
| pub fn timestamp(&self) -> u64 { | |||
There was a problem hiding this comment.
I'm rather sad this comes as a u64. Perhaps that's already a mistake in iroh-sync? Or just implementation details leaking out? But for a user-level Rust API I'd much rather see something like time::OffsetDateTime or so.
There was a problem hiding this comment.
we already use u64s for timestamps in the whole codebase, lets ship this as is, and improve on that later
3 tasks
dignifiedquire
approved these changes
Jan 15, 2024
fubuloubu
pushed a commit
to ApeWorX/iroh
that referenced
this pull request
Feb 21, 2024
## Description <!-- A summary of what this pull request achieves and a rough list of changes. --> ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [ ] Self-review. - [ ] Documentation updates if relevant. - [ ] Tests if relevant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Notes & open questions
Change checklist