refactor(iroh-net): Remove incremental state from reportgen actor #2180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reportgen actor was carrying this "incremental" state around in two ways: as an Option in last_report and as a boolean in incremental. It's simpler to have less state and only carry it as an Option.
rklaehn
approved these changes
Apr 15, 2024
4 tasks
Frando
added a commit
that referenced
this pull request
Apr 29, 2024
## Description This adds a test for iroh-dns-server with mainline fallback resolution. Needed to rework the config structure a little to not duplicate code too much. ## Breaking Changes are documented in #2180 ## Notes & open questions <!-- Any notes, remarks or open questions you have to make about the PR. --> ## Change checklist - [x] Self-review. - [x] Documentation updates if relevant. - [x] Tests if relevant. - [x] All breaking changes documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The reportgen actor was carrying this "incremental" state around in
two ways: as an Option in last_report and as a boolean in incremental.
It's simpler to have less state and only carry it as an Option.
Notes & open questions
Change checklist
[ ] Documentation updates if relevant.[ ] Tests if relevant.