Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support git-describe #31

Closed
nathansgreen opened this issue Mar 15, 2017 · 3 comments
Closed

Support git-describe #31

nathansgreen opened this issue Mar 15, 2017 · 3 comments

Comments

@nathansgreen
Copy link
Contributor

maven-git-commit-id-plugin supports git-describe. In particular, it supports marking "dirty" working copies, so it's clear whether a given build was from a completely clean checkout. Any modification to a committed file will produce a dirty state, leading to a build that may not be reproducible.

@izeye
Copy link
Contributor

izeye commented Aug 7, 2017

@nathansgreen @n0mer Resolved via #32 ?

@n0mer
Copy link
Owner

n0mer commented Jan 4, 2018

@izeye @nathansgreen fixed in 1.4.18

@n0mer n0mer closed this as completed Jan 4, 2018
@tha2015
Copy link
Collaborator

tha2015 commented Mar 21, 2018

I compared the generated value for git.commit.id.describe and the values from "git describe" command and the git-commit-id-maven-plugin

The "git describe" command and the git-commit-id-maven-plugin generated the same value and they are different to the value from this Gradle plugin. So I'd like to reopen this issue to review/update the implementation for git.commit.id.describe to make sure we are generating the same value as "git describe" and git-commit-id-maven-plugin.

@tha2015 tha2015 reopened this Mar 21, 2018
tha2015 added a commit that referenced this issue Mar 21, 2018
* Fix issue #31 (Support git-describe)
@tha2015 tha2015 closed this as completed Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants