Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

By default, git.commit.time should be formatted with dateFormat = "yyyy-MM-dd'T'HH:mm:ssZ" and dateFormatTimeZone = "${user.timezone}" #71

Closed
tha2015 opened this issue Mar 21, 2018 · 0 comments
Milestone

Comments

@tha2015
Copy link
Collaborator

tha2015 commented Mar 21, 2018

Spring boot expects git.commit.time in the format of
yyyy-MM-dd’T’HH:mm:ssZ
(see https://docs.spring.io/spring-boot/docs/current/reference/html/howto-build.html#howto-git-info)

The maven-git-commit-id-plugin also uses default configs when generating git.commit.time value
dateFormat = yyyy-MM-dd'T'HH:mm:ssZ
dateFormatTimeZone = ${user.timezone}

Currently this Gradle plugin generates git.commit.time as a Unix timestamp value which is not very human friendly.

I suggest that we should format git.commit.id by default to a human friendly value using the below default configs:
dateFormat = yyyy-MM-dd'T'HH:mm:ssZ
dateFormatTimeZone = ${user.timezone}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant