Add support for configuration cache

[joschi]

Remove problematic invocations in the task action and replace them with the recommended replacements from the Gradle documentation.

https://docs.gradle.org/6.8.3/userguide/configuration_cache.html
https://docs.gradle.org/6.8.3/userguide/lazy_configuration.html

Closes #160

[joschi]

@n0mer @tha2015 This PR contains the changes from #162 and #163 too, so depending on whether you want to merge those PRs, I can adapt this PR accordingly.

[joschi]

@tha2015 I've rebased the PR on the latest master branch and included the last missing part from #158.

Let me know if you have any questions about the changes in this PR. 😄

[tha2015]

Hi @joschi , sorry for the delay. I was busy and could not spend much time to review and test the changes for backward compatibility. Could you help to verify that it works on Gradle 4.x and also increase the plugin version? Then I will release it. Thanks.

• Thai

[joschi]

Could you help to verify that it works on Gradle 4.x

The changes won't work on Gradle 4.x because of some changes regarding how to build instances of DirectoryProperty.

• https://docs.gradle.org/4.10/javadoc/org/gradle/api/file/DirectoryProperty.html
• https://docs.gradle.org/5.6/javadoc/org/gradle/api/file/DirectoryProperty.html

This being said, I've made the plugin work with Gradle 5.1 up to Gradle 7.0-rc1 (see BackwardCompatibilityFunctionalTest) with a few exemptions from Gradle 6.0-6.3 because of a bug in Gradle's handling of properties (see comments in test).

Gradle 4.10.3 has been released on Dec 05, 2018 (more than two years ago).
Should this plugin still support Gradle 4.x?

[tha2015]

Thanks for the info. Agreed that we don't have to support it anymore. We will just need to change the plugin's major version and put a note so people will be able about this change.

[joschi]

@tha2015 I've update the backward-compatibility test to skip tests on unsupported Java versions, bumped the plugin version to 2.3.0, and added a compatibility matrix in the README.

[joschi]

@tha2015 Thanks for checking! I think I've caught them all now.

[tha2015]

FYI, I've published it but it is not approved yet.

Task :publishPlugins
Publishing plugin com.gorylenko.gradle-git-properties version 2.3.0
Thank you. Your new plugin com.gorylenko.gradle-git-properties has been submitted for approval by Gradle engineers. The
request should be processed within the next few days, at which point you will be contacted via email.

[joschi]

@tha2015 Thanks for merging! 😄

Could we tag the release in this repository?
The latest tag is still https://github.com/n0mer/gradle-git-properties/releases/tag/v.2.2.4.

[tha2015]

Thanks, I've created the tag.

…

On Mon, Mar 29, 2021 at 5:26 AM Jochen Schalanda ***@***.***> wrote: @tha2015 <https://github.com/tha2015> Thanks for merging! 😄 Could we tag the release in this repository? The latest tag is still https://github.com/n0mer/gradle-git-properties/releases/tag/v.2.2.4. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#164 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADTHP6UT6TQVKEJ5QHZJX6LTGB5X7ANCNFSM4ZDZFUIA> .