-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken links on github comments #6
Conversation
n0th1ng-else
commented
Aug 14, 2019
•
edited
Loading
edited
- docs(readme): Fix code blocks
- chore(circleci): Reuse the same executer
- chore(circleci): Collect job numbers
- docs(readme): Add circleci badge
.circleci/bot.js
Outdated
let data = ''; | ||
|
||
resp.on('data', chunk => { | ||
data = data + chunk; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use +=
.circleci/bot.js
Outdated
bot.comment(token, body); | ||
} | ||
|
||
function getLink(url, title = 'report') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title is unused?
README.md
Outdated
}); | ||
|
||
pageSize.update(oldSize => { | ||
return oldSize + 10; | ||
return oldSize + 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename oldSize
to oldValue
as it is below
🎉 This PR is included in version 1.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |