Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links on github comments #6

Merged
merged 4 commits into from
Aug 18, 2019
Merged

Fix broken links on github comments #6

merged 4 commits into from
Aug 18, 2019

Conversation

n0th1ng-else
Copy link
Owner

@n0th1ng-else n0th1ng-else commented Aug 14, 2019

  • docs(readme): Fix code blocks
  • chore(circleci): Reuse the same executer
  • chore(circleci): Collect job numbers
  • docs(readme): Add circleci badge

Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
Repository owner deleted a comment from n0th1ng-else-circle-bot Aug 15, 2019
@n0th1ng-else-circle-bot

docs(readme): Add circleci badge

Coverage: report
Test results: report
Semantic release info: report

@n0th1ng-else n0th1ng-else changed the title Infra Fix broken links on github comments Aug 15, 2019
.circleci/bot.js Outdated
let data = '';

resp.on('data', chunk => {
data = data + chunk;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use +=

.circleci/bot.js Outdated
bot.comment(token, body);
}

function getLink(url, title = 'report') {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title is unused?

README.md Outdated
});

pageSize.update(oldSize => {
return oldSize + 10;
return oldSize + 10;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename oldSize to oldValue as it is below

@n0th1ng-else-circle-bot

docs(readme): Add circleci badge

Coverage: report
Test results: report
Semantic release info: report

@n0th1ng-else n0th1ng-else merged commit ac03154 into master Aug 18, 2019
@n0th1ng-else n0th1ng-else deleted the infra branch August 18, 2019 15:18
@n0th1ng-else
Copy link
Owner Author

🎉 This PR is included in version 1.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants