-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Props.edit is always false, even when set to true. #12
Comments
Yes , @PAK90 , i am facing a similar issue. |
@PAK90 and @ashishd751 So that you can change the edit functionality dynamically using edit property. |
@knnemade99 works as you said, but is it a bug, isn't it? |
Yes, it is a bug.
And Kunal's answer is just a workaround.
On 23-Aug-2017 4:44 PM, "Raul de Melo" <notifications@github.com> wrote:
@knnemade99 <https://github.com/knnemade99> works as you said, but is it a
bug, isn't it?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AICJeSU8VXNvH21Eokc_Ob1BU6P42Tw4ks5sbAl4gaJpZM4LqN3i>
.
|
Thank you - I will take a look soon. |
<ReactStars size={40} |
@vaibhavvv9 const isEditProp = isEdit ? undefiend : true; Then use above variable in following code <ReactStars size={40} count={4} In this way if isEdit is true, it will be editable and if isEdit is false, it wont be editable. |
Weird bug; the only way I can set the 'edit' prop to true is by not including it in my settings object. If I include it, even when it's set to true, it appears as false. I think it's due to this line which overrides the value to 'false' when
props.edit == true
, since the typeof it is not undefined.The text was updated successfully, but these errors were encountered: