This repository has been archived by the owner on May 23, 2024. It is now read-only.
#183 #184
Merged
#183 #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#183
I didn't see a contribution guide. I updated the package.json and ran the tests. The new code failed before updating THREE (because of invert not being a function, as expected), and succeeded after.
I made one token line contribution to the README, though I'm not sure what you really want there, or how you want to handle this as a release, etc.
Let me know what changes are preferred, or if you'd prefer instead to copy/paste code for this method and include it internally somehow, etc.