Skip to content

Commit

Permalink
fix(core): Ensure that all non-lazy-loaded community nodes get post-p…
Browse files Browse the repository at this point in the history
…rocessed correctly (#5782)

If you install a community node with `polling: true`, activating a workflow with that node fails with an error: `WorkflowActivationError: There was a problem activating the workflow: "Could not get parameter "pollTimes"!"`.

You can test this by installing `n8n-nodes-rss-feed-trigger`, creating a workflow with the `RSS Trigger` node, and then trying to activate it. Activation will fail on `master`, but work as expected on this branch.
  • Loading branch information
netroy committed Mar 24, 2023
1 parent 161de11 commit 30aeeb7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/cli/src/commands/start.ts
Expand Up @@ -60,7 +60,7 @@ export class Start extends BaseCommand {
}),
};

protected activeWorkflowRunner = Container.get(ActiveWorkflowRunner);
protected activeWorkflowRunner: ActiveWorkflowRunner;

/**
* Opens the UI in browser
Expand Down Expand Up @@ -200,6 +200,7 @@ export class Start extends BaseCommand {
await this.initCrashJournal();
await super.init();
this.logger.info('Initializing n8n process');
this.activeWorkflowRunner = Container.get(ActiveWorkflowRunner);

await this.initLicense();
await this.initBinaryManager();
Expand Down

0 comments on commit 30aeeb7

Please sign in to comment.