fix(core): Assign properties.success earlier to set executionStatus c…

…orrectly
n8n-io · Mar 24, 2023 · 6c7772a · 6c7772a
1 parent 1663319
commit 6c7772a
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/packages/cli/src/InternalHooks.ts b/packages/cli/src/InternalHooks.ts
@@ -284,6 +284,8 @@ export class InternalHooks implements IInternalHooksClass {
 			properties.user_id = userId;
 		}
 
+		properties.success = !!runData?.finished;
+
 		let executionStatus: ExecutionStatus;
 		if (runData?.status === 'crashed') {
 			executionStatus = 'crashed';
@@ -295,7 +297,6 @@ export class InternalHooks implements IInternalHooksClass {
 
 		if (runData !== undefined) {
 			properties.execution_mode = runData.mode;
-			properties.success = !!runData.finished;
 			properties.is_manual = runData.mode === 'manual';
 
 			let nodeGraphResult: INodesGraphResult | null = null;