Skip to content

Commit

Permalink
ci: Remove eslint diff plugin. Run full linting on PRs (no-changelog) (
Browse files Browse the repository at this point in the history
  • Loading branch information
netroy committed Sep 14, 2023
1 parent 54bf66d commit c18ba37
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 39 deletions.
7 changes: 1 addition & 6 deletions .github/workflows/ci-pull-requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,5 @@ jobs:
path: ./packages/**/dist
key: ${{ github.sha }}-base:18-test-lint

- name: Fetch base branch for `git diff`
run: git fetch origin ${{ github.event.pull_request.base.ref }}:${{ github.event.pull_request.base.ref }}

- name: Run ESLint on changes only
env:
ESLINT_PLUGIN_DIFF_COMMIT: ${{ github.event.pull_request.base.ref }}
- name: Lint
run: pnpm lint
16 changes: 0 additions & 16 deletions packages/@n8n_io/eslint-config/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -491,19 +491,3 @@ const config = (module.exports = {
},
],
});

if ('ESLINT_PLUGIN_DIFF_COMMIT' in process.env) {
/**
* Plugin to lint only changes
*
* https://github.com/paleite/eslint-plugin-diff#plugindiffdiff-recommended
*/
config.plugins.push('eslint-plugin-diff');

/**
* Config for eslint-plugin-diff
*
* https://github.com/paleite/eslint-plugin-diff#plugindiffdiff-recommended
*/
config.extends.push('plugin:diff/diff');
}
1 change: 0 additions & 1 deletion packages/@n8n_io/eslint-config/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
"eslint-config-airbnb-typescript": "^17.1.0",
"eslint-config-prettier": "^8.9.0",
"eslint-import-resolver-typescript": "^3.5.5",
"eslint-plugin-diff": "^2.0.1",
"eslint-plugin-import": "^2.28.0",
"eslint-plugin-n8n-local-rules": "^1.0.0",
"eslint-plugin-prettier": "^5.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import {
MAPPING_COLUMNS_RESPONSE,
NODE_PARAMETER_VALUES,
UPDATED_SCHEMA,
getLatestValueChangeEvent,
} from './utils/ResourceMapper.utils';
import { useNodeTypesStore } from '@/stores/nodeTypes.store';
import { waitAllPromises } from '@/__tests__/utils';
Expand Down
18 changes: 3 additions & 15 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c18ba37

Please sign in to comment.