Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming #5613

Merged
merged 8 commits into from
May 17, 2023

Conversation

agobrech
Copy link
Contributor

@agobrech agobrech commented Mar 3, 2023

@agobrech agobrech changed the title feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming feat(Respond To Webhook Node): Move from Binary Buffer to Binary streaming Mar 3, 2023
@agobrech agobrech changed the title feat(Respond To Webhook Node): Move from Binary Buffer to Binary streaming feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming Mar 3, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Mar 3, 2023
netroy
netroy previously approved these changes Mar 29, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@netroy netroy force-pushed the node-354-support-binary-streaming-for-the-respond branch from 68ffb68 to e3dae5e Compare March 29, 2023 22:23
@netroy netroy requested a review from maspio March 29, 2023 22:24
@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 18.75% and project coverage change: +0.02 🎉

Comparison is base (a4c0cc9) 27.66% compared to head (b4cd7a9) 27.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5613      +/-   ##
==========================================
+ Coverage   27.66%   27.69%   +0.02%     
==========================================
  Files        2938     2947       +9     
  Lines      180030   180850     +820     
  Branches    19551    19631      +80     
==========================================
+ Hits        49810    50089     +279     
- Misses     129487   130016     +529     
- Partials      733      745      +12     
Impacted Files Coverage Δ
...se/nodes/RespondToWebhook/RespondToWebhook.node.ts 0.00% <0.00%> (ø)
packages/workflow/src/Interfaces.ts 50.00% <ø> (ø)
packages/cli/src/WebhookHelpers.ts 11.92% <27.27%> (+0.92%) ⬆️

... and 139 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@netroy netroy force-pushed the node-354-support-binary-streaming-for-the-respond branch from 89e67f7 to 2bae04b Compare May 15, 2023 15:29
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@agobrech agobrech merged commit 8ae2d80 into master May 17, 2023
22 checks passed
@agobrech agobrech deleted the node-354-support-binary-streaming-for-the-respond branch May 17, 2023 08:06
MiloradFilipovic added a commit that referenced this pull request May 19, 2023
* master:
  fix(Google Calendar Node): All day option fix (#6274)
  feat(Gotify Node): Add support for self signed certificates (#6053)
  docs: Remove missed beta text from Notion node (no-changelog) (#6166)
  fix(OpenAI Node): Descriptive errors (#6270)
  fix(SSH Node): Replace ~ with /home/username (#6269)
  feat(core): Replace client-oauth2 with an in-repo package (#6266)
  🚀 Release 0.229.0 (#6267)
  fix: Revert "Replace client-oauth2 with an in-repo package" (no-changelog) (#6265)
  feat(Respond to Webhook Node): Move from Binary Buffer to Binary streaming (#5613)
  feat(core): Replace client-oauth2 with an in-repo package (#6056)
  fix(editor): Fix typo and change text sizes in ExecutionUsage component (no-changelog) (#6261)
@janober
Copy link
Member

janober commented May 25, 2023

Got released with n8n@0.230.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released skip-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants