Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Display correct error message #5634

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Conversation

janober
Copy link
Member

@janober janober commented Mar 7, 2023

When $env is currently used in the UI, it always displays the error message access to env vars denied even if access is actually possible.

This fix is not perfect, but at least tells people that access is not possible via the UI and they have to run the node. Depending on the settings, will it then either return the correct value or, if really deactivated display the correct error message.

Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/add-actual-information-about-env-vars-handling-to-documentation/23829
https://community.n8n.io/t/how-to-get-hostname/21037
https://community.n8n.io/t/no-access-to-env/20665

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Mar 7, 2023
@janober janober merged commit 5f238ea into master Mar 10, 2023
@janober janober deleted the improve-env-error-message branch March 10, 2023 13:16
@janober janober added the Upcoming Release Will be part of the upcoming release label Mar 10, 2023
@janober
Copy link
Member Author

janober commented Mar 16, 2023

Got released with n8n@0.220.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants