fix(HTTP Request Node): Fix AWS credentials to stop removing url params for STS #5790
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
| @@ -285,7 +285,7 @@ export class Aws implements ICredentialType { | |||
| const method = requestOptions.method; | |||
| let body = requestOptions.body; | |||
| let region = credentials.region; | |||
| const query = requestOptions.qs?.query as IDataObject; | |||
| let query = requestOptions.qs?.query as IDataObject; | |||
There was a problem hiding this comment.
should we update this code to either use requestOptions.qs?.query if the JSON object is set, or to create the query object based on rest of the values in requestWithUri.qs, since the UI only allows only one of the options.
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5790 +/- ##
==========================================
- Coverage 14.75% 14.74% -0.01%
==========================================
Files 2475 2475
Lines 113355 113357 +2
Branches 17699 17699
==========================================
- Hits 16727 16720 -7
- Misses 96085 96096 +11
+ Partials 543 541 -2
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
…-sts-correctly-with-the-http
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
Github issue / Community forum post (link here to close automatically):