-
Notifications
You must be signed in to change notification settings - Fork 6.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(HTTP Request Node): Fix AWS credentials to stop removing url params for STS #5790
fix(HTTP Request Node): Fix AWS credentials to stop removing url params for STS #5790
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
@@ -285,7 +285,7 @@ export class Aws implements ICredentialType { | |||
const method = requestOptions.method; | |||
let body = requestOptions.body; | |||
let region = credentials.region; | |||
const query = requestOptions.qs?.query as IDataObject; | |||
let query = requestOptions.qs?.query as IDataObject; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update this code to either use requestOptions.qs?.query
if the JSON object is set, or to create the query object based on rest of the values in requestWithUri.qs
, since the UI only allows only one of the options.
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #5790 +/- ##
==========================================
- Coverage 14.75% 14.74% -0.01%
==========================================
Files 2475 2475
Lines 113355 113357 +2
Branches 17699 17699
==========================================
- Hits 16727 16720 -7
- Misses 96085 96096 +11
+ Partials 543 541 -2
... and 7 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…-sts-correctly-with-the-http
Got released with |
Github issue / Community forum post (link here to close automatically):