-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(editor): Fix Luxon date parsing of ExecutionsUsage component #6333
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6333 +/- ##
=======================================
Coverage 27.67% 27.67%
=======================================
Files 2958 2958
Lines 181374 181379 +5
Branches 19727 19726 -1
=======================================
+ Hits 50189 50191 +2
- Misses 130438 130441 +3
Partials 747 747
☔ View full report in Codecov by Sentry. |
✅ All Cypress E2E specs passed |
* fix(editor): Fix luxon date parsing of ExecutionsUsage component * Fix wrong indent
Got released with |
* master: (54 commits) feat: Version control mvp (#6271) feat(editor): Implement Resource Mapper component (#6207) fix(editor): Update SSO settings styles (#6342) fix: Show `Ask AI` only on Code Node (#6336) feat(core): Add metadata (customdata) to event log (#6334) refactor: Add telemetry to upgrade paths (no-changelog) (#6313) fix(Code Node): Fix `item` and `items` alias regression (#6331) feat: Add manual login option and password reset link for SSO (#6328) fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333) fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322) fix(core): Prevent prototype pollution on injectable services (#6309) fix(core): Optimize getSharedWorkflowIds query (#6314) ci: Reset DB only once per e2e test (no-changelog) (#6216) feat(editor): Bring back checklist experiment (no-changelog) (#6307) fix: Add ldapts to nodes-base package (no-changelog) (#6315) fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318) feat: Add tab visibility change detection when polling executions (no-changelog) (#6311) fix(editor): Fix locale plularisation if count is 0 (#6312) 🚀 Release 0.230.0 (#6310) fix(Execute Command Node): Block executions when `command` is empty (#6308) ...
We have identified an issue where users, under certain circumstances, were presented with a
{n} day left. | {n} days left.
fallback locale. This problem originated from the incorrect parsing of thedaysLeftOnTrial
computation in theExecutionsUsage
component. Specifically, the error surfaced only on canvas when a node contained a subtitle.The root cause of this problem was traced back to an improper call to
getSimpleParameterValue
innodeHelpers.ts
. Here,PLACEHOLDER_FILLED_AT_EXECUTION_TIME
was inaccurately passed as the fourth argument, which should have been the timezone instead.Subsequently, this timezone argument was incorrectly utilized to establish the global Luxon
Settings.defaultZone
within theWorkflowDataProxy
constructor. This action resulted in an error, asPLACEHOLDER_FILLED_AT_EXECUTION_TIME
is not a recognized timezone.Github issue / Community forum post (link here to close automatically):