fix(editor): Fix Luxon date parsing of ExecutionsUsage component #6333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6333 +/- ##
=======================================
Coverage 27.67% 27.67%
=======================================
Files 2958 2958
Lines 181374 181379 +5
Branches 19727 19726 -1
=======================================
+ Hits 50189 50191 +2
- Misses 130438 130441 +3
Partials 747 747
☔ View full report in Codecov by Sentry. |
cstuncsik
approved these changes
May 29, 2023
|
✅ All Cypress E2E specs passed |
maspio
pushed a commit
that referenced
this pull request
May 30, 2023
* fix(editor): Fix luxon date parsing of ExecutionsUsage component * Fix wrong indent
|
Got released with |
MiloradFilipovic
added a commit
that referenced
this pull request
Jun 1, 2023
* master: (54 commits) feat: Version control mvp (#6271) feat(editor): Implement Resource Mapper component (#6207) fix(editor): Update SSO settings styles (#6342) fix: Show `Ask AI` only on Code Node (#6336) feat(core): Add metadata (customdata) to event log (#6334) refactor: Add telemetry to upgrade paths (no-changelog) (#6313) fix(Code Node): Fix `item` and `items` alias regression (#6331) feat: Add manual login option and password reset link for SSO (#6328) fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333) fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322) fix(core): Prevent prototype pollution on injectable services (#6309) fix(core): Optimize getSharedWorkflowIds query (#6314) ci: Reset DB only once per e2e test (no-changelog) (#6216) feat(editor): Bring back checklist experiment (no-changelog) (#6307) fix: Add ldapts to nodes-base package (no-changelog) (#6315) fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318) feat: Add tab visibility change detection when polling executions (no-changelog) (#6311) fix(editor): Fix locale plularisation if count is 0 (#6312) 🚀 Release 0.230.0 (#6310) fix(Execute Command Node): Block executions when `command` is empty (#6308) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have identified an issue where users, under certain circumstances, were presented with a
{n} day left. | {n} days left.fallback locale. This problem originated from the incorrect parsing of thedaysLeftOnTrialcomputation in theExecutionsUsagecomponent. Specifically, the error surfaced only on canvas when a node contained a subtitle.The root cause of this problem was traced back to an improper call to
getSimpleParameterValueinnodeHelpers.ts. Here,PLACEHOLDER_FILLED_AT_EXECUTION_TIMEwas inaccurately passed as the fourth argument, which should have been the timezone instead.Subsequently, this timezone argument was incorrectly utilized to establish the global Luxon
Settings.defaultZonewithin theWorkflowDataProxyconstructor. This action resulted in an error, asPLACEHOLDER_FILLED_AT_EXECUTION_TIMEis not a recognized timezone.Github issue / Community forum post (link here to close automatically):