Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Optimize getSharedWorkflowIds query #6314

Merged
merged 11 commits into from
May 26, 2023

Conversation

flipswitchingmonkey
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Make sure to check off this list before asking for review.

packages/cli/src/WorkflowHelpers.ts Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch coverage: 52.94% and no project coverage change.

Comparison is base (7a7b884) 27.66% compared to head (2ab86b1) 27.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6314   +/-   ##
=======================================
  Coverage   27.66%   27.67%           
=======================================
  Files        2958     2958           
  Lines      181357   181369   +12     
  Branches    19723    19726    +3     
=======================================
+ Hits        50179    50188    +9     
  Misses     130433   130433           
- Partials      745      748    +3     
Impacted Files Coverage Δ
packages/cli/src/workflows/workflows.services.ts 50.93% <0.00%> (ø)
packages/cli/src/WorkflowHelpers.ts 42.77% <37.50%> (-0.91%) ⬇️
packages/cli/src/config/index.ts 42.50% <75.00%> (+4.26%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels May 24, 2023
packages/cli/src/WorkflowHelpers.ts Outdated Show resolved Hide resolved
packages/cli/src/WorkflowHelpers.ts Outdated Show resolved Hide resolved
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <netroy@users.noreply.github.com>
packages/cli/src/WorkflowHelpers.ts Outdated Show resolved Hide resolved
packages/cli/src/WorkflowHelpers.ts Outdated Show resolved Hide resolved
netroy
netroy previously approved these changes May 24, 2023
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

2 similar comments
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

netroy
netroy previously approved these changes May 25, 2023
@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@netroy netroy merged commit 0631f69 into master May 26, 2023
@netroy netroy deleted the optimize_getsharedworkflowids branch May 26, 2023 16:02
csuermann pushed a commit that referenced this pull request May 26, 2023
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
maspio pushed a commit that referenced this pull request May 30, 2023
Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
@janober
Copy link
Member

janober commented May 31, 2023

Got released with n8n@0.230.2

MiloradFilipovic added a commit that referenced this pull request Jun 1, 2023
* master: (54 commits)
  feat: Version control mvp (#6271)
  feat(editor): Implement Resource Mapper component (#6207)
  fix(editor): Update SSO settings styles (#6342)
  fix: Show `Ask AI` only on Code Node (#6336)
  feat(core): Add metadata (customdata) to event log (#6334)
  refactor: Add telemetry to upgrade paths (no-changelog) (#6313)
  fix(Code Node): Fix `item` and `items` alias regression (#6331)
  feat: Add manual login option and password reset link for SSO (#6328)
  fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333)
  fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322)
  fix(core): Prevent prototype pollution on injectable services (#6309)
  fix(core): Optimize getSharedWorkflowIds query (#6314)
  ci: Reset DB only once per e2e test (no-changelog) (#6216)
  feat(editor): Bring back checklist experiment (no-changelog) (#6307)
  fix: Add ldapts to nodes-base package (no-changelog) (#6315)
  fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318)
  feat: Add tab visibility change detection when polling executions (no-changelog) (#6311)
  fix(editor): Fix locale plularisation if count is 0 (#6312)
  🚀 Release 0.230.0 (#6310)
  fix(Execute Command Node): Block executions when `command` is empty (#6308)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants