New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Show Ask AI
only on Code Node
#6336
fix: Show Ask AI
only on Code Node
#6336
Conversation
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
packages/editor-ui/src/components/CodeNodeEditor/CodeNodeEditor.vue
Outdated
Show resolved
Hide resolved
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6336 +/- ##
========================================
Coverage 27.65% 27.66%
========================================
Files 2958 2958
Lines 181379 181522 +143
Branches 19723 19731 +8
========================================
+ Hits 50165 50221 +56
- Misses 130467 130553 +86
- Partials 747 748 +1
☔ View full report in Codecov by Sentry. |
|
✅ All Cypress E2E specs passed |
* master: (54 commits) feat: Version control mvp (#6271) feat(editor): Implement Resource Mapper component (#6207) fix(editor): Update SSO settings styles (#6342) fix: Show `Ask AI` only on Code Node (#6336) feat(core): Add metadata (customdata) to event log (#6334) refactor: Add telemetry to upgrade paths (no-changelog) (#6313) fix(Code Node): Fix `item` and `items` alias regression (#6331) feat: Add manual login option and password reset link for SSO (#6328) fix(editor): Fix Luxon date parsing of ExecutionsUsage component (#6333) fix(core): Do not track errored workflow executions for automated executions (no-changelog) (#6322) fix(core): Prevent prototype pollution on injectable services (#6309) fix(core): Optimize getSharedWorkflowIds query (#6314) ci: Reset DB only once per e2e test (no-changelog) (#6216) feat(editor): Bring back checklist experiment (no-changelog) (#6307) fix: Add ldapts to nodes-base package (no-changelog) (#6315) fix(Code Node): Update vm2 to address CVE-2023-32313 (#6318) feat: Add tab visibility change detection when polling executions (no-changelog) (#6311) fix(editor): Fix locale plularisation if count is 0 (#6312) 🚀 Release 0.230.0 (#6310) fix(Execute Command Node): Block executions when `command` is empty (#6308) ...
Got released with |
The Code Node Editor has started to be used outside the Code node. Fixing the immediate issue for now, but more generally since this is being used more widely we should refactor it to make it more generic and rename it as well in future.
https://linear.app/n8n/issue/ADO-761/bug-ask-ai-button-is-shown-in-edit-pinned-data-modal