feat(editor): Prevent saving of workflow when canvas is loading

[OlegIvaniv]

Some of our users have encountered an issue where saving an empty workflow through a keyboard shortcut could override an existing workflow. To address this problem, within the saveCurrentWorkflow function, we implemented a check to determine if the canvas is loading in which case we prevent saving.
We need to include genericHelpers mixin in workflowHelpers to get the loadingService. This caused an issue due to genericHelpers isReadOnly property. It was clashing with some other component's isReadOnly when imported together in workflowHelpers to fix this, I had to rename isReadOnly to isReadOnlyRoute.
I also added pruning of activated workflows before pruning the DB. This seemed to have fixed the SQLITE error that we sometimes see in our e2e specs.
Github issue / Community forum post (link here to close automatically):

[github-actions]

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

• If fixing bug, added test to cover scenario.
• If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

• Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

• Used composition API for all new components.
• Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

• Added E2E if adding new features.
• Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/mixins/**:

• Avoided adding new mixins (use composables instead). Only removed code from here.

Files matching packages/editor-ui/src/views/NodeView.vue:

• Avoided adding code here. Only refactored to make it smaller.

Files matching cypress/e2e/**:

• Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
• Spoofed endpoints that are not critical for the test (to avoid flakiness).
• Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
• Avoided adding waits on time (use request intercepts instead).
• Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

[github-actions]

⚠️ Some Cypress E2E specs are failing, please fix them before merging

[cypress]

3 flaky tests on run #1339 ↗︎

0

228

0

0

3

Details:

🌳 help-218_prevent_saving_of_pristine_workflow 🖥️ browsers:node18.12.0-chrome1...
Project: n8n	Commit: 85a10f1960
Status: Passed	Duration: 06:54 💡
Started: Jun 27, 2023 10:52 AM	Ended: Jun 27, 2023 10:59 AM

  18-user-management.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
User Management > should delete user and transfer their data		Output Screenshots Video

  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items		Output Screenshots Video

  15-scheduler-node.cy.ts • 1 flaky test

View Output Video

Test		Artifacts
Schedule Trigger node > should execute once per second when activated		Output Screenshots Video

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[codecov]

Codecov Report

Patch coverage: 42.10% and project coverage change: +0.12 🎉

Comparison is base (f0ab023) 28.65% compared to head (85a10f1) 28.77%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6497      +/-   ##
==========================================
+ Coverage   28.65%   28.77%   +0.12%     
==========================================
  Files        3000     3032      +32     
  Lines      186310   187007     +697     
  Branches    20601    20695      +94     
==========================================
+ Hits        53390    53817     +427     
- Misses     132110   132353     +243     
- Partials      810      837      +27     

Impacted Files	Coverage Δ
packages/cli/src/api/e2e.api.ts	0.00% <0.00%> (ø)
...es/editor-ui/src/components/RunDataJsonActions.vue	52.54% <0.00%> (ø)
packages/editor-ui/src/mixins/workflowHelpers.ts	14.25% <33.33%> (+0.02%)	⬆️
packages/editor-ui/src/views/NodeView.vue	13.47% <40.00%> (ø)
packages/editor-ui/src/mixins/genericHelpers.ts	60.00% <50.00%> (ø)
packages/editor-ui/src/components/RunData.vue	70.08% <83.33%> (+0.03%)	⬆️
...ckages/editor-ui/src/components/ExpressionEdit.vue	63.71% <100.00%> (ø)
...kages/editor-ui/src/components/NodeCredentials.vue	38.76% <100.00%> (ø)

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[github-actions]

✅ All Cypress E2E specs passed

[janober]

Got released with n8n@0.235.0