Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove PostHog event calls #6915

Merged
merged 11 commits into from
Aug 17, 2023
Merged

feat: Remove PostHog event calls #6915

merged 11 commits into from
Aug 17, 2023

Conversation

RicardoE105
Copy link
Contributor

@RicardoE105 RicardoE105 commented Aug 11, 2023 •
edited
Loading

TO-DO:

  • Delete posthog-js FE hooks

@RicardoE105 RicardoE105 changed the title Remove PostHog event calls feat: Remove PostHog event calls Aug 11, 2023
@github-actions
Copy link
Contributor

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 29.26% and no project coverage change.

Comparison is base (e6cff3f) 25.14% compared to head (9c2b663) 25.14%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6915   +/-   ##
=======================================
  Coverage   25.14%   25.14%           
=======================================
  Files        3150     3150           
  Lines      192013   192070   +57     
  Branches    21157    21161    +4     
=======================================
+ Hits        48280    48300   +20     
- Misses     142751   142788   +37     
  Partials      982      982
Files Changed Coverage Δ
packages/cli/src/InternalHooks.ts 5.75% <0.00%> (ø)
packages/cli/src/Server.ts 0.00% <ø> (ø)
packages/cli/src/commands/worker.ts 0.00% <0.00%> (ø)
packages/cli/src/config/schema.ts 37.50% <ø> (ø)
packages/cli/src/telemetry/index.ts 47.67% <0.00%> (ø)
packages/editor-ui/src/api/users.ts 23.56% <0.00%> (ø)
packages/editor-ui/src/stores/users.store.ts 39.69% <0.00%> (ø)
...es/editor-ui/src/views/TemplatesCollectionView.vue 0.00% <0.00%> (ø)
...ages/editor-ui/src/views/TemplatesWorkflowView.vue 0.00% <0.00%> (ø)
packages/editor-ui/src/stores/posthog.store.ts 73.54% <35.00%> (-4.70%) ⬇️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mutdmour
mutdmour reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mutdmour mutdmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cleaner to update track function instead to support Posthog.. what do you think?

packages/editor-ui/src/plugins/telemetry/index.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

@cypress
Copy link

cypress bot commented Aug 17, 2023 •
edited
Loading

1 flaky tests on run #1917 ↗︎

0 228 0 0 Flakiness 1

Details:

🌳 ado-963-feature-remove-posthog-event-calls 🖥️ browsers:node18.12.0-chrome107...
Project: n8n Commit: 9c2b6637a7
Status: Passed Duration: 07:19 💡
Started: Aug 17, 2023 3:31 PM Ended: Aug 17, 2023 3:39 PM
Flakiness  cypress/e2e/18-user-management.cy.ts • 1 flaky test

View Output Video

Test Artifacts
User Management > should delete user and transfer their data Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

OlegIvaniv
OlegIvaniv approved these changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@OlegIvaniv OlegIvaniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@RicardoE105 RicardoE105 merged commit 270946a into master Aug 17, 2023
49 of 50 checks passed
@RicardoE105 RicardoE105 deleted the ado-963-feature-remove-posthog-event-calls branch August 17, 2023 15:39
This was referenced Aug 23, 2023
Closed
Merged
krynble added a commit that referenced this pull request Aug 23, 2023
@github-actions @krynble
🚀 Release 1.4.0 (#7001)
0e89a65 
# [1.4.0](https://github.com/n8n-io/n8n/compare/n8n@1.3.0...n8n@1.4.0)
(2023-08-23)


### Bug Fixes

* **core:** Add recoveryInProgress flag file
([#6962](#6962))
([7b96820](7b96820))
* **core:** Fix `continueOnFail` for expression error in Set
([#6939](#6939))
([d4fac05](d4fac05))
* **core:** Fix `import:workflow` command
([#6996](#6996))
([8c38d85](8c38d85))
* **core:** Replace throw with warning when deactivating a non-active
workflow ([#6969](#6969))
([b6a00fe](b6a00fe))
* **core:** Set up OAuth2 cred test
([#6960](#6960))
([4fc69b7](4fc69b7))
* **editor:** Do not flag dynamic load options issue on expression
([#6932](#6932))
([60a1ef0](60a1ef0))
* **editor:** Ensure community node install button tracks user agreement
([#6976](#6976))
([0ddfc73](0ddfc73))
* **editor:** Fix parsing for single quoted resolvables
([#6982](#6982))
([f32e993](f32e993))
* **editor:** Fix Remove all fields not removing values in resource
mapper ([#6940](#6940))
([e6cff3f](e6cff3f))
* **editor:** Prevent Code node linter from erroring on `null` parse
([#6934](#6934))
([40d3a29](40d3a29))
* **Google Sheets Node:** Fix short sheet name interpreted as range
([#6989](#6989))
([00268a0](00268a0))
* **Google Sheets Trigger Node:** Support sheet names with non-latin
characters ([#6970](#6970))
([052dd7c](052dd7c))
* **GraphQL Node:** Improve error handling
([#6955](#6955))
([41db637](41db637))
* **Mautic Node:** Fix issue with owner not being set correctly
([#6991](#6991))
([64b950f](64b950f))
* **Salesforce Node:** Fix Account update owner operation
([#6958](#6958))
([9b27878](9b27878))
* **Shopify Node:** Fix pagination when using options
([#6972](#6972))
([475d9c9](475d9c9))
* **Webhook Node:** Backward compatible form-data parsing for non-array
fields ([#6967](#6967))
([9455bcf](9455bcf))


### Features

* **core:** Add a warning to error workflows that cannot be started due
to permission or settings
([#6961](#6961))
([67b88f7](67b88f7))
* **core:** Add support for ready hooks, and credentials overwrite
endpoint in workers ([#6954](#6954))
([8f8a1de](8f8a1de))
* **editor:** Show banner for non-production licenses
([#6943](#6943))
([413570c](413570c))
* Remove PostHog event calls
([#6915](#6915))
([270946a](270946a))
* **Send Email Node:** Add support for sending text and html email
simultaneously ([#6978](#6978))
([3860d41](3860d41))

Co-authored-by: krynble <krynble@users.noreply.github.com>
@janober
Copy link
Member

janober commented Aug 30, 2023

Got released with n8n@1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutdmour mutdmour mutdmour approved these changes

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RicardoE105 @janober @mutdmour @OlegIvaniv