fix(core): Add recoveryInProgress flag file #6962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
core
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #6962 +/- ##
==========================================
- Coverage 25.13% 25.13% -0.01%
==========================================
Files 3150 3150
Lines 192105 192152 +47
Branches 21159 21170 +11
==========================================
+ Hits 48288 48291 +3
- Misses 142835 142879 +44
Partials 982 982
☔ View full report in Codecov by Sentry. |
krynble
reviewed
Aug 18, 2023
packages/cli/src/eventbus/MessageEventBusWriter/MessageEventBusLogWriterWorker.ts
Outdated
Show resolved
Hide resolved
|
|
Passing run #1941 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
|
krynble
approved these changes
Aug 18, 2023
|
✅ All Cypress E2E specs passed |
flipswitchingmonkey
deleted the
pay-679-improve-the-event-log-recovery-code
branch
krynble
added a commit
that referenced
this pull request
Aug 23, 2023
# [1.4.0](https://github.com/n8n-io/n8n/compare/n8n@1.3.0...n8n@1.4.0) (2023-08-23) ### Bug Fixes * **core:** Add recoveryInProgress flag file ([#6962](#6962)) ([7b96820](7b96820)) * **core:** Fix `continueOnFail` for expression error in Set ([#6939](#6939)) ([d4fac05](d4fac05)) * **core:** Fix `import:workflow` command ([#6996](#6996)) ([8c38d85](8c38d85)) * **core:** Replace throw with warning when deactivating a non-active workflow ([#6969](#6969)) ([b6a00fe](b6a00fe)) * **core:** Set up OAuth2 cred test ([#6960](#6960)) ([4fc69b7](4fc69b7)) * **editor:** Do not flag dynamic load options issue on expression ([#6932](#6932)) ([60a1ef0](60a1ef0)) * **editor:** Ensure community node install button tracks user agreement ([#6976](#6976)) ([0ddfc73](0ddfc73)) * **editor:** Fix parsing for single quoted resolvables ([#6982](#6982)) ([f32e993](f32e993)) * **editor:** Fix Remove all fields not removing values in resource mapper ([#6940](#6940)) ([e6cff3f](e6cff3f)) * **editor:** Prevent Code node linter from erroring on `null` parse ([#6934](#6934)) ([40d3a29](40d3a29)) * **Google Sheets Node:** Fix short sheet name interpreted as range ([#6989](#6989)) ([00268a0](00268a0)) * **Google Sheets Trigger Node:** Support sheet names with non-latin characters ([#6970](#6970)) ([052dd7c](052dd7c)) * **GraphQL Node:** Improve error handling ([#6955](#6955)) ([41db637](41db637)) * **Mautic Node:** Fix issue with owner not being set correctly ([#6991](#6991)) ([64b950f](64b950f)) * **Salesforce Node:** Fix Account update owner operation ([#6958](#6958)) ([9b27878](9b27878)) * **Shopify Node:** Fix pagination when using options ([#6972](#6972)) ([475d9c9](475d9c9)) * **Webhook Node:** Backward compatible form-data parsing for non-array fields ([#6967](#6967)) ([9455bcf](9455bcf)) ### Features * **core:** Add a warning to error workflows that cannot be started due to permission or settings ([#6961](#6961)) ([67b88f7](67b88f7)) * **core:** Add support for ready hooks, and credentials overwrite endpoint in workers ([#6954](#6954)) ([8f8a1de](8f8a1de)) * **editor:** Show banner for non-production licenses ([#6943](#6943)) ([413570c](413570c)) * Remove PostHog event calls ([#6915](#6915)) ([270946a](270946a)) * **Send Email Node:** Add support for sending text and html email simultaneously ([#6978](#6978)) ([3860d41](3860d41)) Co-authored-by: krynble <krynble@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: during startup, unfinished executions trigger a recovery process that, under certain circumstances, can in itself crash the instance (e.g. by running our of memory), resulting in an infinite recovery loop
This PR aims to change this behaviour by writing a flag file when the recovery process starts, and removing it when it finishes. In the case of a crash, this flag will persist and upon the next attempt, the recovery will instead do the absolute minimal (marking executions as 'crashed'), without attempting any 'crashable' actions.