fix(editor): Do not flag dynamic load options issue on expression #6932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
n8n-assistant
bot
added
n8n team
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #6932 +/- ##
==========================================
- Coverage 24.86% 24.86% -0.01%
==========================================
Files 3144 3144
Lines 191225 191225
Branches 21096 21095 -1
==========================================
- Hits 47546 47545 -1
- Misses 142698 142699 +1
Partials 981 981
☔ View full report in Codecov by Sentry. |
|
|
Passing run #1889 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
✅ All Cypress E2E specs passed |
What would you suggest? I think we've been here before - I hesitate to add to e2e for this, and this is a huge legacy component that's not easy to unit test right now. Edit: Plus this is a mini UX improvement (i.e. not something that broke recently) so I wonder if it's best use of time to find an efficient way to test this, even if I'd like to. |
|
I would say e2e tests are fine.. better that than seeing this bug again.. it's your call though 🙂 I already approved |
ivov
deleted the
pay-631-validation-error-should-not-show-when-on-expr-mode-and-error
branch
netroy
pushed a commit
that referenced
this pull request
Aug 18, 2023
) Story: https://linear.app/n8n/issue/PAY-631 1. Set a Linear node to update an issue. 2. Add an invalid Linear cred. 3. In `Update Fields`, set `State Name or ID` to an expression. → No loading issue should be flagged. 4. Switch back to fixed mode. → Loading issue should be flagged. <img width="289" alt="Capture 2023-08-15 at 15 58 53@2x" src="https://github.com/n8n-io/n8n/assets/44588767/0e34220c-0e62-417f-90c6-5a48aa12bf4b"> <img width="373" alt="Capture 2023-08-15 at 15 58 38@2x" src="https://github.com/n8n-io/n8n/assets/44588767/137c8f5a-1ece-4f02-ae0d-e1bc56e9c9dd">
Merged
|
Got released with |
krynble
added a commit
that referenced
this pull request
Aug 23, 2023
# [1.4.0](https://github.com/n8n-io/n8n/compare/n8n@1.3.0...n8n@1.4.0) (2023-08-23) ### Bug Fixes * **core:** Add recoveryInProgress flag file ([#6962](#6962)) ([7b96820](7b96820)) * **core:** Fix `continueOnFail` for expression error in Set ([#6939](#6939)) ([d4fac05](d4fac05)) * **core:** Fix `import:workflow` command ([#6996](#6996)) ([8c38d85](8c38d85)) * **core:** Replace throw with warning when deactivating a non-active workflow ([#6969](#6969)) ([b6a00fe](b6a00fe)) * **core:** Set up OAuth2 cred test ([#6960](#6960)) ([4fc69b7](4fc69b7)) * **editor:** Do not flag dynamic load options issue on expression ([#6932](#6932)) ([60a1ef0](60a1ef0)) * **editor:** Ensure community node install button tracks user agreement ([#6976](#6976)) ([0ddfc73](0ddfc73)) * **editor:** Fix parsing for single quoted resolvables ([#6982](#6982)) ([f32e993](f32e993)) * **editor:** Fix Remove all fields not removing values in resource mapper ([#6940](#6940)) ([e6cff3f](e6cff3f)) * **editor:** Prevent Code node linter from erroring on `null` parse ([#6934](#6934)) ([40d3a29](40d3a29)) * **Google Sheets Node:** Fix short sheet name interpreted as range ([#6989](#6989)) ([00268a0](00268a0)) * **Google Sheets Trigger Node:** Support sheet names with non-latin characters ([#6970](#6970)) ([052dd7c](052dd7c)) * **GraphQL Node:** Improve error handling ([#6955](#6955)) ([41db637](41db637)) * **Mautic Node:** Fix issue with owner not being set correctly ([#6991](#6991)) ([64b950f](64b950f)) * **Salesforce Node:** Fix Account update owner operation ([#6958](#6958)) ([9b27878](9b27878)) * **Shopify Node:** Fix pagination when using options ([#6972](#6972)) ([475d9c9](475d9c9)) * **Webhook Node:** Backward compatible form-data parsing for non-array fields ([#6967](#6967)) ([9455bcf](9455bcf)) ### Features * **core:** Add a warning to error workflows that cannot be started due to permission or settings ([#6961](#6961)) ([67b88f7](67b88f7)) * **core:** Add support for ready hooks, and credentials overwrite endpoint in workers ([#6954](#6954)) ([8f8a1de](8f8a1de)) * **editor:** Show banner for non-production licenses ([#6943](#6943)) ([413570c](413570c)) * Remove PostHog event calls ([#6915](#6915)) ([270946a](270946a)) * **Send Email Node:** Add support for sending text and html email simultaneously ([#6978](#6978)) ([3860d41](3860d41)) Co-authored-by: krynble <krynble@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://linear.app/n8n/issue/PAY-631
Update Fields, setState Name or IDto an expression. → No loading issue should be flagged.