fix(Postgres Node): Connection pool of the database object has been destroyed #7074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…postgres-connection-pool-of-the-database-fix
michael-radency
added
n8n team
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
netroy
reviewed
Sep 1, 2023
| @@ -161,15 +161,28 @@ export async function execute( | |||
| db: PgpDatabase, | |||
| ): Promise<INodeExecutionData[]> { | |||
| items = replaceEmptyStringsByNulls(items, nodeOptions.replaceEmptyStrings as boolean); | |||
| const nodeVersion = nodeOptions.typeVersion as number; | |||
There was a problem hiding this comment.
This code seems to be duplicated a few times. Is there anything we can reduce this code duplication?
There was a problem hiding this comment.
added helper to remove duplication
…postgres-connection-pool-of-the-database-fix
Joffcom
previously approved these changes
Sep 1, 2023
|
|
Passing run #2064 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
…postgres-connection-pool-of-the-database-fix
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #7074 +/- ##
=======================================
Coverage 32.10% 32.10%
=======================================
Files 3188 3188
Lines 195871 195892 +21
Branches 21355 21356 +1
=======================================
+ Hits 62878 62898 +20
Misses 131961 131961
- Partials 1032 1033 +1
☔ View full report in Codecov by Sentry. |
Joffcom
approved these changes
Sep 1, 2023
|
✅ All Cypress E2E specs passed |
michael-radency
deleted the
node-728-postgres-connection-pool-of-the-database-fix
branch
Merged
netroy
added a commit
that referenced
this pull request
Sep 6, 2023
# [1.6.0](https://github.com/n8n-io/n8n/compare/n8n@1.5.1...n8n@1.6.0) (2023-09-06) ### Bug Fixes * **core:** Add support for in-transit encryption (TLS) on Redis connections ([#7047](#7047)) ([a910757](a910757)) * **core:** Disallow orphan executions ([#7069](#7069)) ([8a28e98](8a28e98)) * **core:** Split event bus controller into community and ee ([#7107](#7107)) ([011ee2e](011ee2e)) * **editor:** Standardize save text ([#7093](#7093)) ([58b3492](58b3492)) * Ensure all new executions are saved ([#7061](#7061)) ([b8e06d2](b8e06d2)) * Load remote resources even if expressions in non requried parameters resolve ([#6987](#6987)) ([8a8d4e8](8a8d4e8)) * **Postgres Node:** Connection pool of the database object has been destroyed ([#7074](#7074)) ([9dd5f0e](9dd5f0e)) * **Postgres Node:** Tunnel doesn't always close ([#7087](#7087)) ([58e55ba](58e55ba)) ### Features * **core:** Add list query middleware to credentials ([#7041](#7041)) ([fd78021](fd78021)) * **core:** Add support for floating licenses ([#7090](#7090)) ([e26553f](e26553f)) * **core:** Migration for soft deletions for executions ([#7088](#7088)) ([413e0bc](413e0bc)) * **HTTP Request Node:** Determine binary file name from content-disposition headers ([#7032](#7032)) ([273d091](273d091)) * **TheHive Node:** Overhaul ([#6457](#6457)) ([73e782e](73e782e)) Co-authored-by: netroy <netroy@users.noreply.github.com>
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github issue / Community forum post (link here to close automatically):
https://community.n8n.io/t/serious-error-in-postgres-node/29531
https://community.n8n.io/t/postgres-error-connection-pool-of-the-database-object-has-been-destroyed/28983
https://community.n8n.io/t/i-am-getting-an-error-in-a-new-postgres-node-when-using-insert-or-update-operation/26147