Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(editor): Standardize save text #7093

Merged
merged 4 commits into from
Sep 4, 2023
Merged

fix(editor): Standardize save text #7093

merged 4 commits into from
Sep 4, 2023

Conversation

StarfallProjects
Copy link
Contributor

Github issue / Community forum post (link here to close automatically):

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Make sure to check off this list before asking for review.

Joffcom
Joffcom previously approved these changes Sep 4, 2023
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (400949d) 32.11% compared to head (ba508be) 32.11%.
Report is 3 commits behind head on master.

❗ Current head ba508be differs from pull request most recent head 5875dfd. Consider uploading reports for the commit 5875dfd to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7093   +/-   ##
=======================================
  Coverage   32.11%   32.11%           
=======================================
  Files        3188     3188           
  Lines      195897   195900    +3     
  Branches    21358    21359    +1     
=======================================
+ Hits        62907    62908    +1     
- Misses     131958   131960    +2     
  Partials     1032     1032           
Files Changed Coverage Δ
...ages/editor-ui/src/components/WorkflowSettings.vue 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 4, 2023

Passing run #2083 ↗︎

0 238 0 0 Flakiness 0

Details:

🌳 standardize-save-text 🖥️ browsers:node18.12.0-chrome107 🤖 StarfallProjects ...
Project: n8n Commit: 5875dfd1fe
Status: Passed Duration: 07:43 💡
Started: Sep 4, 2023 2:18 PM Ended: Sep 4, 2023 2:26 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

✅ All Cypress E2E specs passed

Joffcom
Joffcom previously approved these changes Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

✅ All Cypress E2E specs passed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

✅ All Cypress E2E specs passed

@Joffcom Joffcom merged commit 58b3492 into master Sep 4, 2023
17 checks passed
@Joffcom Joffcom deleted the standardize-save-text branch September 4, 2023 14:28
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
netroy added a commit that referenced this pull request Sep 6, 2023
# [1.6.0](https://github.com/n8n-io/n8n/compare/n8n@1.5.1...n8n@1.6.0)
(2023-09-06)


### Bug Fixes

* **core:** Add support for in-transit encryption (TLS) on Redis
connections ([#7047](#7047))
([a910757](a910757))
* **core:** Disallow orphan executions
([#7069](#7069))
([8a28e98](8a28e98))
* **core:** Split event bus controller into community and ee
([#7107](#7107))
([011ee2e](011ee2e))
* **editor:** Standardize save text
([#7093](#7093))
([58b3492](58b3492))
* Ensure all new executions are saved
([#7061](#7061))
([b8e06d2](b8e06d2))
* Load remote resources even if expressions in non requried parameters
resolve ([#6987](#6987))
([8a8d4e8](8a8d4e8))
* **Postgres Node:** Connection pool of the database object has been
destroyed ([#7074](#7074))
([9dd5f0e](9dd5f0e))
* **Postgres Node:** Tunnel doesn't always close
([#7087](#7087))
([58e55ba](58e55ba))


### Features

* **core:** Add list query middleware to credentials
([#7041](#7041))
([fd78021](fd78021))
* **core:** Add support for floating licenses
([#7090](#7090))
([e26553f](e26553f))
* **core:** Migration for soft deletions for executions
([#7088](#7088))
([413e0bc](413e0bc))
* **HTTP Request Node:** Determine binary file name from
content-disposition headers
([#7032](#7032))
([273d091](273d091))
* **TheHive Node:** Overhaul
([#6457](#6457))
([73e782e](73e782e))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 6, 2023

Got released with n8n@1.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants