Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Code Node): Disable WASM to address CVE-2023-37903 #7122

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(Code Node): Disable WASM to address CVE-2023-37903 #7122

merged 1 commit into from
Sep 6, 2023

Conversation

netroy
Copy link
Member

@netroy netroy commented Sep 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching packages/**/*.ts:

  • Added unit tests to cover new or updated functionality.

Files matching packages/nodes-base/nodes/**:

  • Added workflow tests for nodes if possible.

Make sure to check off this list before asking for review.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team node/improvement New feature or request labels Sep 6, 2023
@cypress
Copy link

cypress bot commented Sep 6, 2023

Passing run #2122 ↗︎

0 238 0 0 Flakiness 0

Details:

🌳 fix-CVE-2023-37903 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project: n8n Commit: 9ab19177ca
Status: Passed Duration: 07:12 💡
Started: Sep 6, 2023 1:59 PM Ended: Sep 6, 2023 2:06 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

✅ All Cypress E2E specs passed

@netroy netroy merged commit 36a8e91 into master Sep 6, 2023
52 checks passed
@netroy netroy deleted the fix-CVE-2023-37903 branch September 6, 2023 14:11
@netroy netroy mentioned this pull request Sep 6, 2023
Merged
netroy added a commit that referenced this pull request Sep 7, 2023
@netroy
fix(core): Disable Node.js custom inspection to address CVE-2023-37903 (
a223734 
#7125)

This seems like a better fix than #7122
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
netroy added a commit that referenced this pull request Sep 13, 2023
@github-actions @netroy
🚀 Release 1.7.0 (#7158)
6e41cba 
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0)
(2023-09-13)


### Bug Fixes

* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122](#7122))
([36a8e91](36a8e91))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123](#7123))
([0a35025](0a35025))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125](#7125))
([a223734](a223734)),
closes [#7122](#7122)
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094](#7094))
([67092c0](67092c0))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129](#7129))
([c9b7948](c9b7948))
* **editor:** Update git repo url validation regex
([#7151](#7151))
([e51f173](e51f173))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136](#7136))
([915cfa0](915cfa0))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582](#5582))
([6e5a4f6](6e5a4f6))
* **Postgres Node:** Fix automatic column mapping
([#7121](#7121))
([92af131](92af131))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959](#6959))
([fd800b6](fd800b6))


### Features

* **core:** Add an option to enable WAL mode for SQLite
([#7118](#7118))
([1d1a022](1d1a022))
* **core:** Add commands to workers to respond with current state
([#7029](#7029))
([7b49cf2](7b49cf2))
* **Salesforce Node:** Add fax field to lead option
([#7030](#7030))
([01f875a](01f875a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
netroy added a commit that referenced this pull request Sep 13, 2023
@github-actions @netroy
🚀 Release 1.7.0 (#7162)
a6e027b 
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0)
(2023-09-13)


### Bug Fixes

* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122](#7122))
([36a8e91](36a8e91))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123](#7123))
([0a35025](0a35025))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125](#7125))
([a223734](a223734))
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094](#7094))
([67092c0](67092c0))
* **editor:** Tweak hover area of workflow / cred cards
([#7108](#7108))
([217de21](217de21))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129](#7129))
([c9b7948](c9b7948))
* **editor:** Update git repo url validation regex
([#7151](#7151))
([e51f173](e51f173))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136](#7136))
([915cfa0](915cfa0))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582](#5582))
([6e5a4f6](6e5a4f6))
* **Postgres Node:** Fix automatic column mapping
([#7121](#7121))
([92af131](92af131))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959](#6959))
([fd800b6](fd800b6))


### Features

* **core:** Add an option to enable WAL mode for SQLite
([#7118](#7118))
([1d1a022](1d1a022))
* **core:** Add commands to workers to respond with current state
([#7029](#7029))
([7b49cf2](7b49cf2))
* **Salesforce Node:** Add fax field to lead option
([#7030](#7030))
([01f875a](01f875a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 14, 2023

Got released with n8n@1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valya valya valya approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team node/improvement New feature or request Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@netroy @janober @valya