Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(editor): Rebind endpoint events when component activated #7129

Merged
merged 6 commits into from
Sep 13, 2023
Merged

fix(editor): Rebind endpoint events when component activated #7129

merged 6 commits into from
Sep 13, 2023

Conversation

cstuncsik
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited
Loading

Great PR! Please pay attention to the following items before merging:

Files matching packages/**:

  • If fixing bug, added test to cover scenario.
  • If addressing forum or Github issue, added link to description.

Files matching **/*.vue:

  • Used composition API for all new components.
  • Added component or unit tests to cover functionality.

Files matching packages/editor-ui/**/*.vue:

  • Added E2E if adding new features.
  • Used design system tokens (colors, spacings...) where possible.

Files matching packages/editor-ui/src/views/NodeView.vue:

  • Avoided adding code here. Only refactored to make it smaller.

Files matching cypress/e2e/**:

  • Avoided chaining commands more than two or three times (to avoid flakiness because only last one will be retried).
  • Spoofed endpoints that are not critical for the test (to avoid flakiness).
  • Picked most efficient path to start the test (for example skipped account setup and starting at /workflow/new for a canvas test).
  • Avoided adding waits on time (use request intercepts instead).
  • Ensured each spec does not depend on any another spec to pass.

Make sure to check off this list before asking for review.

@codecov
Copy link

codecov bot commented Sep 7, 2023 •
edited
Loading

Codecov Report

Patch coverage: 7.69% and project coverage change: -0.01% ⚠️

Comparison is base (5c6cccd) 32.00% compared to head (2ccdc1f) 31.99%.
Report is 6 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7129      +/-   ##
==========================================
- Coverage   32.00%   31.99%   -0.01%     
==========================================
  Files        3277     3277              
  Lines      197964   197973       +9     
  Branches    21593    21589       -4     
==========================================
- Hits        63349    63342       -7     
- Misses     133554   133570      +16     
  Partials     1061     1061
Files Changed Coverage Δ
packages/editor-ui/src/views/NodeView.vue 16.89% <7.69%> (+<0.01%) ⬆️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Sep 7, 2023
@cypress
Copy link

cypress bot commented Sep 13, 2023

Passing run #2153 ↗︎

0 239 0 0 Flakiness 0

Details:

🌳 pay-809-workflow-endpoint-click-has-no-effect-after-coming-back-from 🖥️ brow...
Project: n8n Commit: 2ccdc1fde3
Status: Passed Duration: 07:32 💡
Started: Sep 13, 2023 6:22 AM Ended: Sep 13, 2023 6:29 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@github-actions
Copy link
Contributor

✅ All Cypress E2E specs passed

@cstuncsik cstuncsik merged commit c9b7948 into master Sep 13, 2023
53 checks passed
@cstuncsik cstuncsik deleted the pay-809-workflow-endpoint-click-has-no-effect-after-coming-back-from branch September 13, 2023 07:00
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
netroy added a commit that referenced this pull request Sep 13, 2023
@github-actions @netroy
🚀 Release 1.7.0 (#7158)
6e41cba 
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0)
(2023-09-13)


### Bug Fixes

* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122](#7122))
([36a8e91](36a8e91))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123](#7123))
([0a35025](0a35025))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125](#7125))
([a223734](a223734)),
closes [#7122](#7122)
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094](#7094))
([67092c0](67092c0))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129](#7129))
([c9b7948](c9b7948))
* **editor:** Update git repo url validation regex
([#7151](#7151))
([e51f173](e51f173))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136](#7136))
([915cfa0](915cfa0))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582](#5582))
([6e5a4f6](6e5a4f6))
* **Postgres Node:** Fix automatic column mapping
([#7121](#7121))
([92af131](92af131))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959](#6959))
([fd800b6](fd800b6))


### Features

* **core:** Add an option to enable WAL mode for SQLite
([#7118](#7118))
([1d1a022](1d1a022))
* **core:** Add commands to workers to respond with current state
([#7029](#7029))
([7b49cf2](7b49cf2))
* **Salesforce Node:** Add fax field to lead option
([#7030](#7030))
([01f875a](01f875a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Sep 13, 2023
Merged
netroy added a commit that referenced this pull request Sep 13, 2023
@github-actions @netroy
🚀 Release 1.7.0 (#7162)
a6e027b 
# [1.7.0](https://github.com/n8n-io/n8n/compare/n8n@1.6.0...n8n@1.7.0)
(2023-09-13)


### Bug Fixes

* **Code Node:** Disable WASM to address CVE-2023-37903
([#7122](#7122))
([36a8e91](36a8e91))
* **Code Node:** Upgrade vm2 to address CVE-2023-37466
([#7123](#7123))
([0a35025](0a35025))
* **core:** Disable Node.js custom inspection to address CVE-2023-37903
([#7125](#7125))
([a223734](a223734))
* **editor** Account for nanoid workflow ids for subworkflow execute
policy ([#7094](#7094))
([67092c0](67092c0))
* **editor:** Tweak hover area of workflow / cred cards
([#7108](#7108))
([217de21](217de21))
* **editor:** Unbind workflow endpoint events in case of workspace reset
([#7129](#7129))
([c9b7948](c9b7948))
* **editor:** Update git repo url validation regex
([#7151](#7151))
([e51f173](e51f173))
* **Google Cloud Firestore Node:** Fix empty string interpreted as
number ([#7136](#7136))
([915cfa0](915cfa0))
* **HubSpot Node:** Fix issue with contact lists not working
([#5582](#5582))
([6e5a4f6](6e5a4f6))
* **Postgres Node:** Fix automatic column mapping
([#7121](#7121))
([92af131](92af131))
* **Zoho CRM Node:** Fix issue with Sales Order not updating
([#6959](#6959))
([fd800b6](fd800b6))


### Features

* **core:** Add an option to enable WAL mode for SQLite
([#7118](#7118))
([1d1a022](1d1a022))
* **core:** Add commands to workers to respond with current state
([#7029](#7029))
([7b49cf2](7b49cf2))
* **Salesforce Node:** Add fax field to lead option
([#7030](#7030))
([01f875a](01f875a))

Co-authored-by: netroy <netroy@users.noreply.github.com>
@janober
Copy link
Member

janober commented Sep 14, 2023

Got released with n8n@1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlegIvaniv OlegIvaniv OlegIvaniv approved these changes

Assignees
No one assigned
Labels
n8n team Authored by the n8n team Released ui Enhancement in /editor-ui or /design-system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cstuncsik @janober @OlegIvaniv