feat: Add Salesforce Trigger Node #8920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
community
michael-radency
previously approved these changes
Apr 2, 2024
Comment on lines
+192
to
+193
| let triggerResource = triggerOn.slice(0, 1).toUpperCase() + triggerOn.slice(1, -7); | ||
| const changeType = triggerOn.slice(-7); |
There was a problem hiding this comment.
nitpick:
Why not to use something like 'Account_Created' and const [resource, change] = triggerOn.split('_')
that way we would not have magical values like -7 and avoid some unnecessary calculation to capitalize word
michael-radency
approved these changes
Apr 3, 2024
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Trigger node for Salesforce API
Related tickets and issues
Linear: https://linear.app/n8n/issue/NODE-1233/salesforce-trigger-node-new-node
Review / Merge checklist
(no-changelog)otherwise. (conventions)