-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Salesforce Trigger Node #8920
feat: Add Salesforce Trigger Node #8920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
let triggerResource = triggerOn.slice(0, 1).toUpperCase() + triggerOn.slice(1, -7); | ||
const changeType = triggerOn.slice(-7); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick:
Why not to use something like 'Account_Created'
and const [resource, change] = triggerOn.split('_')
that way we would not have magical values like -7
and avoid some unnecessary calculation to capitalize word
Got released with |
Summary
Adds a Trigger node for Salesforce API
Related tickets and issues
Linear: https://linear.app/n8n/issue/NODE-1233/salesforce-trigger-node-new-node
Review / Merge checklist
(no-changelog)
otherwise. (conventions)