fix(editor): Fix missing input panel in node details view #9043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure getInputData always returns an array.
n8n-assistant
bot
added
n8n team
MiloradFilipovic
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
I also couldn't reproduce the original issue but NDV was breaking for this workflow in the same way @tomi described and these changes fixed it
1 flaky test on run #4551 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > Stop listening for trigger event from NDV |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9043 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 4, 2024
* master: fix(core): Ensure only leader handles waiting executions (#9014) fix(editor): Fix execution with wait node (#9051) fix(editor): Issue showing Auth2 callback section when all properties are overriden (#8999) fix(editor): Rerun failed nodes in manual executions (#9050) fix(editor): Canvas showing error toast when clicking outside of "import workflow by url" modal (#9001) fix: Workflows executed from other workflows not stopping (#9010) fix: Fix missing input panel in node details view (#9043) fix(editor): Prevent saving workflow while another save is in progress (#9048)
despairblue
pushed a commit
that referenced
this pull request
Apr 4, 2024
Merged
netroy
changed the title
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I couldn't actually reproduce the missing input panel, but there was unhandled exception when trying to open the NDV. I fixed that and the Input panel was visible for every node.
Make sure getInputData always returns an array.
Before:
Kapture.2024-04-03.at.15.29.07.mp4
After:
Kapture.2024-04-03.at.15.28.34.mp4
Related tickets and issues
https://linear.app/n8n/issue/ADO-1338/missing-input-panel-in-ndv
Review / Merge checklist
(no-changelog)otherwise. (conventions)