fix(editor): Prevent saving workflow while another save is in progress #9048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
tomi
reviewed
Apr 4, 2024
| const saved = await this.workflowHelpers.saveCurrentWorkflow({ name }); | ||
| if (saved) { | ||
| this.isNameEditEnabled = false; | ||
| } | ||
| this.uiStore.removeActiveAction('workflowSaving'); |
There was a problem hiding this comment.
Would probably be good to do this in a try ... finally to make sure we are never left in an inconsistent state
tomi
reviewed
Apr 4, 2024
| WorkflowPage.actions.visit(); | ||
| WorkflowPage.getters.workflowNameInput().invoke('val').then((oldName) => { | ||
| WorkflowPage.getters.workflowNameInputContainer().click(); | ||
| WorkflowPage.getters.workflowNameInput().type('{selectall}'); |
There was a problem hiding this comment.
Is this some Cypress magic to select all the text?
* master: fix(core): Ensure `status` on Axios errors is available to the BE (#9015) fix(editor): Make Webhook node pinnable (#9047) fix(core): Upgrade express to address CVE-2024-29041 (no-changelog) (#9021) fix(editor): Add fallback for expression resolution in multi-output case (#9045) ci(core): Upgrade express-openapi-validator (no-changelog) (#9022) refactor(core): Delete all auth exclusion config and checks (no-changelog) (#9044) fix(editor): Make share modal content scrollable (#9025)
tomi
previously approved these changes
Apr 4, 2024
| if (saved) { | ||
| this.isNameEditEnabled = false; | ||
| } | ||
| // Exception is handled in the helper function |
There was a problem hiding this comment.
Ah I didn't realize that saveCurrentWorkflow already handles exceptions 🙈 In that case the try..finally is probably not needed. Feel free to remove it
There was a problem hiding this comment.
Yeah, I was a bit surprised by try request but thought you saw something I didn't :D Let's remove it since it's cleaner without it
tomi
approved these changes
Apr 4, 2024
|
✅ All Cypress E2E specs passed |
2 flaky tests on run #4550 ↗︎
Details:
|
||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
Review all test suite changes for PR #9048 ↗︎
MiloradFilipovic
added a commit
that referenced
this pull request
Apr 4, 2024
* master: fix(core): Ensure only leader handles waiting executions (#9014) fix(editor): Fix execution with wait node (#9051) fix(editor): Issue showing Auth2 callback section when all properties are overriden (#8999) fix(editor): Rerun failed nodes in manual executions (#9050) fix(editor): Canvas showing error toast when clicking outside of "import workflow by url" modal (#9001) fix: Workflows executed from other workflows not stopping (#9010) fix: Fix missing input panel in node details view (#9043) fix(editor): Prevent saving workflow while another save is in progress (#9048)
despairblue
pushed a commit
that referenced
this pull request
Apr 4, 2024
Merged
|
Got released with |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where users would end up with duplicate workflows when clicking Save button straight from the name input.
Related tickets and issues
Fixes ADO-2077
Review / Merge checklist
(no-changelog)otherwise. (conventions)