fix(editor): Fix issue with case insensitive tags #9071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RicardoE105
changed the title
RicardoE105
changed the title
n8n-assistant
bot
added
n8n team
RicardoE105
changed the title
MiloradFilipovic
approved these changes
Apr 5, 2024
3 flaky tests on run #4596 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9071 ↗︎
|
✅ All Cypress E2E specs passed |
RicardoE105
deleted the
ado-2110-weird-error-when-trying-to-add-a-tag-to-the-wf
branch
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The tag dropdown fails to create a tag if the same text with another casing exists.
Related tickets and issues
https://linear.app/n8n/issue/ADO-2110/weird-error-when-trying-to-add-a-tag-to-the-wf
Before:
https://www.loom.com/share/096f16b52ea74b89bd83a50e5fcd7d6b
Now:
https://www.loom.com/share/5ceb16f9ae934708bf8e7d2013e3b62d
Review / Merge checklist
(no-changelog)otherwise. (conventions)